Make ANDROID_EXTRA_JARS and Java JAR extra_jars accept Path instances

RESOLVED INVALID

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED INVALID
3 years ago
3 months ago

People

(Reporter: nalexander, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Right now these variables are partially in moz.build and partially in Makefile.in.  This ticket tracks making them moz.build Path instances.
(Reporter)

Comment 1

3 years ago
Created attachment 8695508 [details]
MozReview Request: Bug 1200876 - Work in progress on using Path() in extra_jars. r=nalexander

Bug 1200876 - Work in progress on using Path() in extra_jars. r=nalexander

blassey sees issues with absolute paths in backend.mk files building
on Windows.  ted suggests that mozmake expects "Windows native paths",
like 'c:/foo/bar', where-as the existing build backends produce "msys
paths", like /c/foo/bar.

This was a stab at using AbsolutePath() to address this, but
AbsolutePath() doesn't currently do the right thing either.  Posting
this just to show where some of the work would happen and capture the
experiment.
Attachment #8695508 - Flags: review?(nalexander)
(Reporter)

Updated

3 years ago
Attachment #8695508 - Flags: review?(nalexander)
(Reporter)

Comment 2

3 months ago
Instead, I removed the relevant moz.build pieces in https://bugzilla.mozilla.org/show_bug.cgi?id=1255924 and its precursors.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.