1200881 - Work around get_parent_rr() errors in review-request-summary web API

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

Bug 1200615 documents an error in extra_data.get_parent_rr() in which the wrong parent may be returned if there is an old, discarded parent around.  The proper fix is somewhat involved; for now, we should just workaround this by verifying a proper parent/child relationship before returning the family summary.

Comment 1

[Mark Côté [:mcote]]

Correction: we'll just not return summaries of discarded review requests, which aren't really useful anyway.

Comment 2

[Mark Côté [:mcote]]

Attachment: MozReview Request: mozreview: Don't return summaries of discarded review requests (bug 1200881). r?smacleod

mozreview: Don't return summaries of discarded review requests (bug 1200881). r?smacleod

Bug 1200615 documents an error in mozreview.extra_data.get_parent_rr() in
which the wrong parent is returned for a child review request with a
discarded parent.  The proper fix is moving the extra_data structure into a
proper table; for now, we just omit discarded review requests, which aren't
really useful to summarize anyway.

Comment 3

[Steven MacLeod [:smacleod]]

Comment on attachment 8656068 [details]
MozReview Request: mozreview: Don't return summaries of discarded review requests (bug 1200881). r?smacleod

https://reviewboard.mozilla.org/r/18081/#review16299

Comment 4

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/f7b6a0e264ae