Closed Bug 1200884 Opened 5 years ago Closed 5 years ago

Make postmessage-to-client pass.

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Comment on attachment 8655744 [details] [diff] [review]
0010-make-postmessage-to-client-pass.-r-jdm.patch

Review of attachment 8655744 [details] [diff] [review]:
-----------------------------------------------------------------

Want to just update this to match https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-to-client.html ?

::: testing/web-platform/mozilla/tests/service-workers/service-worker/postmessage-to-client.https.html
@@ +27,5 @@
>      function onMessage(e) {
> +      assert_equals(e.bubbles, false, 'message events should not bubble.');
> +      assert_equals(e.cancelable, false, 'message events should not be cancelable.');
> +// XXXkhuey fixme!
> +//      assert_equals(e.source, sw.controller, 'source should be ServiceWorker.');

File a bug about this?
Attachment #8655744 - Flags: review?(josh) → review+
(In reply to Josh Matthews [:jdm] from comment #1)
> Comment on attachment 8655744 [details] [diff] [review]
> 0010-make-postmessage-to-client-pass.-r-jdm.patch
> 
> Review of attachment 8655744 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Want to just update this to match
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/
> WebKit/LayoutTests/http/tests/serviceworker/postmessage-to-client.html ?

We would not pass it because we don't implement ServiceWorkerMessageEvent yet (bug 1143717).

> :::
> testing/web-platform/mozilla/tests/service-workers/service-worker/
> postmessage-to-client.https.html
> @@ +27,5 @@
> >      function onMessage(e) {
> > +      assert_equals(e.bubbles, false, 'message events should not bubble.');
> > +      assert_equals(e.cancelable, false, 'message events should not be cancelable.');
> > +// XXXkhuey fixme!
> > +//      assert_equals(e.source, sw.controller, 'source should be ServiceWorker.');
> 
> File a bug about this?

Also bug 1143717.
https://hg.mozilla.org/mozilla-central/rev/5818bea794a6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.