Devtools theme shows aero fog on tabs toolbar in private mode in fullscreen (vista/win7 using aero theme)

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arni2033, Assigned: Gijs)

Tracking

({regression})

Trunk
Firefox 44
regression
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

(Whiteboard: [devedition-polish])

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8655753 [details]
Dark.png

STR:   (Win7_64, Nightly 43, 32bit, ID 20150901030226, new profile, safe mode)
(Reporter)

Comment 1

3 years ago
Created attachment 8655754 [details]
Light.png
(Assignee)

Comment 2

3 years ago
Is this a regression?
Flags: needinfo?(arni2033)
(Reporter)

Comment 3

3 years ago
I tested Fx36 [ok] and ESR 38 [not ok].
Flags: needinfo?(arni2033)
Keywords: regression
(Assignee)

Updated

3 years ago
Keywords: regressionwindow-wanted
Whiteboard: [devedition-polish]
I've been trying to reproduce this on my Win10 machine with mozregression and haven't been able to so far. Maybe a Win7-specific issue?

arni2033, would you be interested in trying to help narrow this down using the mozregression tool? If so, I'd be happy to help you try to do so.
Flags: needinfo?(arni2033)
(Assignee)

Updated

3 years ago
Summary: Devtools theme has transparent background for tabs toolbar in private mode in fullscreen → Devtools theme shows aero fog on tabs toolbar in private mode in fullscreen (vista/win7 using aero theme)
(Reporter)

Comment 5

3 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> I've been trying to reproduce this on my Win10 machine with mozregression and haven't been able to so far. Maybe a Win7-specific issue?
I think it's WinXP-Win8 -specific judging on media selector in chrome://browser/skin/devedition.css
Here's my investigaion and also a solution that works ("I added this text" on screenshot):
>>>   http://ssmaker.ru/b7bd6df4.png   <<<
I don't have time and traffic to use mozregression now. I'd use it for all regressions I reported if I had time.   (Don't you have a specially organized team for that? I'd join such "team" if I had time. I guess there's lots of people which do have time)
Flags: needinfo?(arni2033)
We don't have a formalized regression hunting team at this time, no. Efforts are underway to improve that, though. But we rely very much on our volunteers to help where possible. If you ever want to get your feet wet, send me an email or ping me on IRC and I'd be happy to help :)
(Assignee)

Comment 7

3 years ago
Created attachment 8662396 [details]
MozReview Request: Bug 1200892 - fix devedition styling of window in fullscreen on vista/win7, r?bgrins

Bug 1200892 - fix devedition styling of window in fullscreen on vista/win7, r?bgrins
Attachment #8662396 - Flags: review?(bgrinstead)
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8662396 [details]
MozReview Request: Bug 1200892 - fix devedition styling of window in fullscreen on vista/win7, r?bgrins

https://reviewboard.mozilla.org/r/19603/#review17875

Looks good to me, thanks!
Attachment #8662396 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/2d5d44ba3a86
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Worth an uplift to Aurora/Beta?
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regressionwindow-wanted
(Assignee)

Comment 12

3 years ago
Comment on attachment 8662396 [details]
MozReview Request: Bug 1200892 - fix devedition styling of window in fullscreen on vista/win7, r?bgrins

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: broken look on some windows versions for devedition theme
[Describe test coverage new/current, TreeHerder]: nope, css only
[Risks and why]: devedition only, css only -- very low risk
[String/UUID change made/needed]: no



devedition theme means it's not useful to uplift to beta.
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8662396 - Flags: approval-mozilla-aurora?
Comment on attachment 8662396 [details]
MozReview Request: Bug 1200892 - fix devedition styling of window in fullscreen on vista/win7, r?bgrins

Minor css fix for dev edition theme, approved for aurora uplift.
Attachment #8662396 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Updated

3 years ago
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.