1200893 - keyboardinterrupt hang sometimes

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

Sometimes hitting ctrl-c, mozregression can take a few seconds to stop.

The root cause is because we are waiting for threads to join, using concurrent.futures. While this module is great, it does not allow the daemon thing that standard python does. So we can't abruptly kill threads on exit, and sometimes mozregression hangs (thus depending on the network as we are mainly doing network related work in threads).

Comment 1

[Julien Pagès (:parkouss)]

Attachment: keyboard interrupt hangs sometimes

So this patch remove the concurrent.future dependency, and allows ctrl-c to finish almost instantly (within 0.1 second, this is not noticeable).

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8655755 [details] [review]
keyboard interrupt hangs sometimes

This looks sensible, it's too bad we can't get concurrent.futures to do what we need here. :(

Comment 3

[Julien Pagès (:parkouss)]

Yes, this seems to be a bug of the backport for python 2.7 of futures, see https://github.com/ross/requests-futures/issues/14.

Comment 4

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/27038a5791a529242eaf38b2ea5758192cf63910.