1200911 - [New Homescreen] sw home button doesn't cancel out of the overlay for homescreen settings.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. long tap on the homescreen
2. tap the home button

Expected: cancel out of the overlay
Actual: scrolls the homescreen to the top.

Note: this doesn't happen on the old homescreen.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1200911-new-homescreen-button-dismiss-dialog > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8656006 [details] [review]
[gaia] Cwiiis:bug1200911-new-homescreen-button-dismiss-dialog > mozilla-b2g:master

While gmarty is away, I think you're the best reviewer for new-homescreen bits, if you don't mind :)

Comment 3

[Alberto Pastor [:albertopq]]

Added some comments on GH. Thanks!

Comment 4

[Chris Lord [:cwiiis]]

Addressed your comments, thanks :)

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8656006 [details] [review]
[gaia] Cwiiis:bug1200911-new-homescreen-button-dismiss-dialog > mozilla-b2g:master

lgtm, thanks!

Comment 6

[Chris Lord [:cwiiis]]

Taken the risk that tests are green and merged: https://github.com/mozilla-b2g/gaia/commit/c63633bd2f7c69d02246fab1d5d35d3a169b3e02

The job got stalled for almost 4 hours, doesn't seem like it's going to recover but I'm reasonably confident that such a small change really shouldn't break anything... I guess we'll find out soon enough (terribly sorry in advance if this ends up backfiring).