1201017 - TypeError: styles.includes is not a function in resource:///components/nsBrowserGlue.js line 501, 61

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Frederik Braun [:freddy] (reo duty for Fx124)]

In some cases, the URL bar in Aurora (42.0a2 (2015-09-01) and previously) stops working. I have to restart the browser to make it fully functional again.

This may be unrelated to the bug I am seeing, but I'm filing all errors I can see in the browser console right now


Affected source lines:
>      let styles = controller.getStyleAt(idx).split(/\s+/);
>      let style = ["autofill", "tag", "bookmark"].find(s => styles.includes(s));
>

Suggested patch: Check if styles is indeed an array, and not undefined.

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

Thank you!

Ugh, another case of using array.includes...  We need to uplift this patch to 42 ASAP.

I don't that error should cause the urlbar to stop working though, which is troubling.  The error happens when nsBrowserGlue observes autocomplete-did-enter-text, and the only thing that broadcasts that notification is the cpp here, which discards the NotifyObservers return value: http://hg.mozilla.org/releases/mozilla-aurora/file/91825878e01a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#l1477

Comment 2

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #1)
> I don't that error should cause the urlbar to stop working though

I don't think that error

Comment 3

[Frederik Braun [:freddy] (reo duty for Fx124)]

(In reply to Drew Willcoxon :adw from comment #2)
> (In reply to Drew Willcoxon :adw from comment #1)
> > I don't that error should cause the urlbar to stop working though
> 
> I don't think that error

Thanks for the quick look! I'll keep filing errors then ;-)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/934ff69fca49

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/934ff69fca49

Comment 6

[Drew Willcoxon :adw]

(In reply to Frederik Braun [:freddyb] (on PTO until Sep 4th) from comment #3)
> Thanks for the quick look! I'll keep filing errors then ;-)

Please do!  Thanks again.

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8656096 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
Adding telemetry to the urlbar in bug 775825 (landed on 42)

[User impact if declined]:
None hopefully since this is just telemetry, although comment 0 mentions that the urlbar stopped working until a restart possibly because of this bug.  But if we don't take it, we'll have to wait another release to get telemetry data because this bug will prevent it from being collected properly.

[Describe test coverage new/current, TreeHerder]:
No new test for this, but telemetry has existing coverage, and I tested this manually.

[Risks and why]:
Low risk, fairly small and isolated change.

[String/UUID change made/needed]:
None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8656096 [details] [diff] [review]
patch

We want better telemetry, taking it.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e714be378aa4