Closed Bug 1201048 Opened 6 years ago Closed 6 years ago

Update moz.b2g.version to 2.5 on master

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Unassigned)

Details

Attachments

(1 file)

In bug 1130632 we added moz.b2g.version and set it to 2.2 on v2.2 and 3.0 on master.  In the meantime, it was decided that 2.5 be released.

https://github.com/mozilla-b2g/gaia/blob/df646da1c97c2b927db227867fca8272837319fc/build/config/common-settings.json#L148

I know this setting is used in buildtime by multilocale.js and by the langpack-builder.  It looks like build/post-manifest uses it too to set the version of the manifest.
(In reply to Staś Małolepszy :stas from comment #0)
> I know this setting is used in buildtime by multilocale.js and by the
> langpack-builder.  It looks like build/post-manifest uses it too to set the
> version of the manifest.

Ricky, do you know if I can safely change the value of this settings to 2.5 on master?
Flags: needinfo?(rchien)
No problem!
Flags: needinfo?(rchien)
Comment on attachment 8655963 [details] [review]
[gaia] stasm:1201048-moz.b2g.version-2.5 > mozilla-b2g:master

Thanks, Ricky.  Sorry, I should have r?'ed you instead of ni.  This is a very simple pull request :)
Attachment #8655963 - Flags: review?(rchien)
Comment on attachment 8655963 [details] [review]
[gaia] stasm:1201048-moz.b2g.version-2.5 > mozilla-b2g:master

LGTM
Attachment #8655963 - Flags: review?(rchien) → review+
Thanks!

https://github.com/mozilla-b2g/gaia/commit/28491c1630995961d8929d8dbdec558972113ac5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.