Closed Bug 1201050 Opened 4 years ago Closed 4 years ago

Convert assorted action commands in listener to use new dispatcher

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-server)

Attachments

(4 files, 1 obsolete file)

No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Summary: Convert listener singleTap to use new dispatcher → Convert assorted action commands in listener to use new dispatcher
Bug 1201050: Part 1: Use dispatcher for listener singleTap

r=dburns
Attachment #8655966 - Flags: review?(dburns)
Bug 1201050: Part 2: Use dispatcher for listener actionChain

r=dburns
Attachment #8655967 - Flags: review?(dburns)
Bug 1201050: Part 3: Unbreak test by using correct imports

Do note that this test is disabeld in the manifest.

r=dburns
Attachment #8655968 - Flags: review?(dburns)
Bug 1201050: Part 4: Use dispatcher for listener mutliAction

r=dburns
Attachment #8655969 - Flags: review?(dburns)
Comment on attachment 8655966 [details]
MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain

https://reviewboard.mozilla.org/r/18063/#review16343
Attachment #8655966 - Flags: review?(dburns) → review+
Comment on attachment 8655967 [details]
MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports

https://reviewboard.mozilla.org/r/18065/#review16345
Attachment #8655967 - Flags: review?(dburns) → review+
Comment on attachment 8655968 [details]
MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction

https://reviewboard.mozilla.org/r/18067/#review16347
Attachment #8655968 - Flags: review?(dburns) → review+
Comment on attachment 8655969 [details]
MozReview Request: Bug 1201050: Part 4: Use dispatcher for listener mutliAction

https://reviewboard.mozilla.org/r/18069/#review16349
Attachment #8655969 - Flags: review?(dburns) → review+
sorry had to back this out for marionette test bustage on test like https://treeherder.mozilla.org/logviewer.html#?job_id=13693405&repo=mozilla-inbound
Flags: needinfo?(ato)
Comment on attachment 8655966 [details]
MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18063/diff/1-2/
Attachment #8655966 - Attachment description: MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener singleTap → MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain
Comment on attachment 8655967 [details]
MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18065/diff/1-2/
Attachment #8655967 - Attachment description: MozReview Request: Bug 1201050: Part 2: Use dispatcher for listener actionChain → MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports
Comment on attachment 8655968 [details]
MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18067/diff/1-2/
Attachment #8655968 - Attachment description: MozReview Request: Bug 1201050: Part 3: Unbreak test by using correct imports → MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction
Attachment #8655969 - Attachment is obsolete: true
Rebased, new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9074cf9ebb25
Flags: needinfo?(ato)
Comment on attachment 8655966 [details]
MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18063/diff/2-3/
Comment on attachment 8655967 [details]
MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18065/diff/2-3/
Comment on attachment 8655968 [details]
MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18067/diff/2-3/
Bug 1201050: Part 4: Pass value directly back to chrome space

r=ato
Comment on attachment 8692522 [details]
MozReview Request: Bug 1201050: Part 4: Pass value directly back to chrome space

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26269/diff/1-2/
Attachment #8692522 - Flags: review?(ato)
Comment on attachment 8692522 [details]
MozReview Request: Bug 1201050: Part 4: Pass value directly back to chrome space

https://reviewboard.mozilla.org/r/26269/#review23719

Self-review.
Attachment #8692522 - Flags: review?(ato) → review+
It turns out actions.js was passing {value: val || null} to the onSuccess callback.  The new dispatching technique automatically wraps primitives in a {value: …} dict for you, so the return packet to the client was “double wrapped”.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc9acd0bc70&group_state=expanded
You need to log in before you can comment on or make changes to this bug.