Closed
Bug 1201050
Opened 9 years ago
Closed 8 years ago
Convert assorted action commands in listener to use new dispatcher
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(4 files, 1 obsolete file)
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Keywords: ateam-marionette-server
Assignee | ||
Updated•9 years ago
|
Summary: Convert listener singleTap to use new dispatcher → Convert assorted action commands in listener to use new dispatcher
Assignee | ||
Comment 1•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d26e1f458893
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1201050: Part 1: Use dispatcher for listener singleTap r=dburns
Attachment #8655966 -
Flags: review?(dburns)
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1201050: Part 2: Use dispatcher for listener actionChain r=dburns
Attachment #8655967 -
Flags: review?(dburns)
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1201050: Part 3: Unbreak test by using correct imports Do note that this test is disabeld in the manifest. r=dburns
Attachment #8655968 -
Flags: review?(dburns)
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1201050: Part 4: Use dispatcher for listener mutliAction r=dburns
Attachment #8655969 -
Flags: review?(dburns)
Comment 6•9 years ago
|
||
Comment on attachment 8655966 [details] MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain https://reviewboard.mozilla.org/r/18063/#review16343
Attachment #8655966 -
Flags: review?(dburns) → review+
Comment 7•9 years ago
|
||
Comment on attachment 8655967 [details] MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports https://reviewboard.mozilla.org/r/18065/#review16345
Attachment #8655967 -
Flags: review?(dburns) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8655968 [details] MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction https://reviewboard.mozilla.org/r/18067/#review16347
Attachment #8655968 -
Flags: review?(dburns) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8655969 [details] MozReview Request: Bug 1201050: Part 4: Use dispatcher for listener mutliAction https://reviewboard.mozilla.org/r/18069/#review16349
Attachment #8655969 -
Flags: review?(dburns) → review+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e79580a76a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/6a443c2a3482 https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9da85eaf6a https://hg.mozilla.org/integration/mozilla-inbound/rev/ff3a5e493a9f
Comment 11•9 years ago
|
||
sorry had to back this out for marionette test bustage on test like https://treeherder.mozilla.org/logviewer.html#?job_id=13693405&repo=mozilla-inbound
Flags: needinfo?(ato)
Comment 12•9 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b750ebed0ef
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8655966 [details] MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18063/diff/1-2/
Attachment #8655966 -
Attachment description: MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener singleTap → MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8655967 [details] MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18065/diff/1-2/
Attachment #8655967 -
Attachment description: MozReview Request: Bug 1201050: Part 2: Use dispatcher for listener actionChain → MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8655968 [details] MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18067/diff/1-2/
Attachment #8655968 -
Attachment description: MozReview Request: Bug 1201050: Part 3: Unbreak test by using correct imports → MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction
Assignee | ||
Updated•9 years ago
|
Attachment #8655969 -
Attachment is obsolete: true
Assignee | ||
Comment 16•9 years ago
|
||
Rebased, new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9074cf9ebb25
Flags: needinfo?(ato)
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8655966 [details] MozReview Request: Bug 1201050: Part 1: Use dispatcher for listener actionChain Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18063/diff/2-3/
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8655967 [details] MozReview Request: Bug 1201050: Part 2: Unbreak test by using correct imports Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18065/diff/2-3/
Assignee | ||
Comment 19•9 years ago
|
||
Comment on attachment 8655968 [details] MozReview Request: Bug 1201050: Part 3: Use dispatcher for listener mutliAction Review request updated; see interdiff: https://reviewboard.mozilla.org/r/18067/diff/2-3/
Assignee | ||
Comment 20•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33bc6c753bb6&group_state=expanded
Assignee | ||
Comment 21•9 years ago
|
||
Bug 1201050: Part 4: Pass value directly back to chrome space r=ato
Assignee | ||
Comment 22•9 years ago
|
||
Comment on attachment 8692522 [details] MozReview Request: Bug 1201050: Part 4: Pass value directly back to chrome space Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26269/diff/1-2/
Attachment #8692522 -
Flags: review?(ato)
Assignee | ||
Comment 23•9 years ago
|
||
Comment on attachment 8692522 [details] MozReview Request: Bug 1201050: Part 4: Pass value directly back to chrome space https://reviewboard.mozilla.org/r/26269/#review23719 Self-review.
Attachment #8692522 -
Flags: review?(ato) → review+
Assignee | ||
Comment 24•9 years ago
|
||
It turns out actions.js was passing {value: val || null} to the onSuccess callback. The new dispatching technique automatically wraps primitives in a {value: …} dict for you, so the return packet to the client was “double wrapped”. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc9acd0bc70&group_state=expanded
Comment 25•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba8cd968866a https://hg.mozilla.org/integration/mozilla-inbound/rev/238dd6c3aef7 https://hg.mozilla.org/integration/mozilla-inbound/rev/25ee0b9f4a49 https://hg.mozilla.org/integration/mozilla-inbound/rev/1f2b651a5d29
Comment 26•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ba8cd968866a https://hg.mozilla.org/mozilla-central/rev/238dd6c3aef7 https://hg.mozilla.org/mozilla-central/rev/25ee0b9f4a49 https://hg.mozilla.org/mozilla-central/rev/1f2b651a5d29
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•