Make symbol uploads retry on any 500-level error

RESOLVED FIXED in Firefox 42, Firefox OS v2.2

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: ted)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox41 wontfix, firefox42 fixed, firefox43 fixed, firefox-esr38 fixed, b2g-v2.0 wontfix, b2g-v2.0M wontfix, b2g-v2.1 wontfix, b2g-v2.1S wontfix, b2g-v2.2 fixed, b2g-v2.2r fixed, b2g-master fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Bug 1171527 added retries for 500 ISE, but we still occasionally 504s that are fatal. Can we just retry for any 500-level failure?

https://treeherder.mozilla.org/logviewer.html#?job_id=2104598&repo=mozilla-central
(Assignee)

Comment 1

2 years ago
Created attachment 8657067 [details]
MozReview Request: bug 1201069 - retry symbol upload on any 500 error. r?ryanvm

bug 1201069 - retry symbol upload on any 500 error. r?ryanvm
Attachment #8657067 - Flags: review?(ryanvm)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8657067 [details]
MozReview Request: bug 1201069 - retry symbol upload on any 500 error. r?ryanvm

https://reviewboard.mozilla.org/r/18281/#review16549

LGTM, thanks!
Attachment #8657067 - Flags: review?(ryanvm) → review+
(Reporter)

Comment 3

2 years ago
Once this lands successfully on m-c, this should be uplifted a=NPOTB across all supported branches to avoid random build failures when uploading symbols.
Assignee: nobody → ted
status-b2g-v2.0: --- → wontfix
status-b2g-v2.0M: --- → wontfix
status-b2g-v2.1: --- → wontfix
status-b2g-v2.1S: --- → affected
status-b2g-v2.2: --- → affected
status-b2g-v2.2r: --- → affected
status-b2g-master: --- → affected
status-firefox41: --- → affected
status-firefox42: --- → affected
status-firefox43: --- → affected
status-firefox-esr38: --- → affected
Flags: needinfo?(cbook)

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b10b2ae78f3
https://hg.mozilla.org/mozilla-central/rev/5b10b2ae78f3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Reporter)

Comment 6

2 years ago
Still ought to uplift this...
status-b2g-v2.1S: affected → wontfix
status-b2g-master: affected → fixed
status-firefox41: affected → wontfix
Comment on attachment 8657067 [details]
MozReview Request: bug 1201069 - retry symbol upload on any 500 error. r?ryanvm

[Triage Comment]
Indeed, approved after a discussion with Tomcat
Attachment #8657067 - Flags: approval-mozilla-beta+
Attachment #8657067 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-beta/rev/6e9626c5b769
status-firefox42: affected → fixed
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5a8574453182
Flags: needinfo?(cbook)
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/5a8574453182
status-b2g-v2.2: affected → fixed
status-b2g-v2.2r: affected → fixed
https://hg.mozilla.org/releases/mozilla-esr38/rev/74309c6b2b9d
status-firefox-esr38: affected → fixed
You need to log in before you can comment on or make changes to this bug.