1201106 - When the 'directory' attribute is set on <input type=file>, .files must be set to null

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

When the 'directory' attribute is set on <input type=file>, .files must be set to null. See the text "If this attribute is set, input.files MUST return null.":

  https://wicg.github.io/directory-upload/proposal.html#attributes-1

For the rational, see:

  https://github.com/WICG/directory-upload/issues/8

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8659227 [details] [diff] [review]
patch

Review of attachment 8659227 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLInputElement.cpp
@@ +2480,5 @@
>    if (mType != NS_FORM_INPUT_FILE) {
>      return nullptr;
>    }
>  
> +  if (HasAttr(kNameSpaceID_None, nsGkAtoms::directory)) {

Don't we want to check the value as well?

Comment 3

[Jonathan Watt [:jwatt]]

No, it's a boolean attribute.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86014d39a1c5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86014d39a1c5