1201120 - Write a build script that eliminates IIFEs for classes in the flash.* package.

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Michael Bebenita [:mbx]]

All classes in the flash package have their own .ts files. For the following code:

module Shumway.AVMX.AS.flash.net {
  export class URLVariables { ... }
}

TSC emits JS code that looks something like:


(function (Shumway) {
    var AVMX;
    (function (AVMX) {
        var AS;
        (function (AS) {
            var flash;
            (function (flash) {
                var net;
                (function (net) {
                    var URLVariables = (function (_super) {
                    ....
                    })(AS.ASObject);
                    net.URLVariables = URLVariables;
                })(net = flash.net || (flash.net = {}));
            })(flash = AS.flash || (AS.flash = {}));
        })(AS = AVMX.AS || (AVMX.AS = {}));
    })(AVMX = Shumway.AVMX || (Shumway.AVMX = {}));
})(Shumway || (Shumway = {}));

One way to solve this problem would be to merge all classes in a package in a single .ts file. Another way would be to write a post processing script that eliminates this cruft.

Comment 1

[Till Schneidereit [:till]]

Attachment: Link to Github pull-request: https://github.com/mozilla/shumway/pull/2370

Fixed by running a post-processing script that eliminates 1117 closures in build/bundles/shumway.player.js and 77 in build/bundles/shumway.gfx.js.