1201131 - [swift 2.0] Cancelled Requests in Firefox Account Login tests

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Emily Toop (:fluffyemily)]

When executing Firefox Account integration tests, the request is being cancelled before execution causing the tests to fail.

I have no idea why this is happening. The cancel() on the Alamofire request is never called, but the response that we receive is 

FAILURE: Error Domain=NSURLErrorDomain Code=-999 "cancelled" UserInfo={NSErrorFailingURLKey=https://api.accounts.firefox.com/v1/account/login?keys=true, NSLocalizedDescription=cancelled, NSErrorFailingURLStringKey=https://api.accounts.firefox.com/v1/account/login?keys=true} 
  ▿ Failure : 2 elements
    ▿ .0 : Optional(<>)

The NSURLErrorDomain -999 occurs when a request is cancelled, or another request is executed that causes the existing request to cancel. I can see neither request() being called more than once, nor cancel() being called on the Alamofire request object.

The failing tests are:

Sync -> LiveAccountStorageTests -> testLive() and testStateMachine()
Accounts -> SyncAuthStateTests -> testLive()

Issues occur when calling FxAClient10: login() using test account information.

Logging in and syncing using the test account works totally fine from within the app.

Comment 1

[Richard Newman [:rnewman]]

I'm looking at this for a little while.

Note for those who come after: the failing AccountsTest has been changed so it doesn't fail, but still needs attention.

Comment 2

[Richard Newman [:rnewman]]

I think we're not retaining the request somehow, and so it's deiniting, which cancels the session.

Comment 3

[Richard Newman [:rnewman]]

Yup, that's it.

Each Client has its own Alamofire.Manager. We don't use the client once it kicks off its request, so it's automatically released. When it's released, it releases the Manager. The Manager's deinit cancels all outstanding requests.

Threading the client back through the call stack makes this test pass. I'd like to find a neater solution :)

Comment 4

[Richard Newman [:rnewman]]

Attachment: Pull request

Comment 5

[Richard Newman [:rnewman]]

f80cd8d