120122 - port of 0.9.7 code to OpenUNIX needs defines

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P3)

Description

[Hiram Clawson]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; OpenUNIX i386; en-US; rv:0.9.7) Gecko/20020112
BuildID:    2001122108

Porting Mozilla 0.9.7 code to OpenUNIX
Need the defines in:
xpcom/reflect/xptcall/src/md/unix/Makefile.in
xpcom/reflect/xptcall/src/md/unix/xptc_platforms_unixish_x86.h

Reproducible: Always
Steps to Reproduce:
1.Build source on OpenUNIX
2.
3.

Comment 1

[Hiram Clawson]

Attachment: patch to xpcom source to add support for OpenUnix port

If you know of a more efficient method to get OpenUnix in on one of
the other ifdef's in the Makefile.in, please make it so.

Thanks for your assistance,

--Hiram - [e-mail]

Comment 2

[Phil Schwartau]

Formally confirming bug for consideration -

Comment 3

[David Bradley]

I'm not real comfortable reviewing this change, as I'm not real up on the build
framework whe it comes to UNIX/Linux. It looks fine to me, but I wonder if there
other issues lurking about that need to be addressed as well.

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 65048 [details] [diff] [review]
patch to xpcom source to add support for OpenUnix port

This looks reasonable.	Do the xpconnect tests pass on OpenUnixWare with this
applied?

Comment 5

[hacker formerly known as [e-mail]]

Comment on attachment 65048 [details] [diff] [review]
patch to xpcom source to add support for OpenUnix port

r=cls

Comment 6

[Hiram Clawson]

Mike asked if the xpconnect tests pass with this patch.

The first thing the patch does is allow the xpcom business to build.
So I need the patch to at least get a build.  Then

Does the test mean running: js/src/xpconnect/tests/TestXPC ?

When I do try that, I get the following results:

Individual SecurityManager tests...
  build wrapper with veto: TEST NOT RUN
  build wrapper no veto: FAILED
  getService no veto: passed
  getService with veto: passed
  createInstance no veto: passed
  getService with veto: passed
  call method no veto:  : FAILED
  call method with veto:  : passed
  get attribute no veto:  : FAILED
  get attribute with veto:  : passed
  set attribute no veto:  : FAILED
  set attribute with veto:  : passed
SecurityManager tests : FAILED
ArgumentFormatter test:  could not convert from native to JS -- FAILED!
ThreadJSContextStack tests...
        stack->GetCount() : passed
        stack->Push() passed
        stack->GetCount() : passed
        stack->Push/Peek : passed
        stack->Push/Pop : passed
        stack->GetCount() : passed

Which does indicate some failures with the no-veto tests.

What would I look at to examine these errors ?

Comment 7

[David Bradley]

Hard to say, have you tried running TestXPTCInvoke?

Comment 8

[Hiram Clawson]

I found some work-arounds to compiler problems I'm having, and now TestXPC
runs without errors.  Although it does have a new message at the beginning:

nsNativeComponentLoader: autoregistering begins.
nsNativeComponentLoader: autoregistering succeeded
nNCL: registering deferred (0)

got category manager
got enumerator
e.GetNext() FAILED with result 8000ffff
no pending XPC exception

Individual SecurityManager tests...
  build wrapper with veto: TEST NOT RUN
  build wrapper no veto: passed
... etc


I don't know if that is OK.

I have also now ported this to a second operating system which would
make this patch read, based on the 0.9.8 source base:

*** Makefile.in.0       Mon Jan  7 21:46:51 2002
--- Makefile.in Thu Feb  7 14:33:23 2002
***************
*** 45,50 ****
--- 45,57 ----
  #
  # Lots of Unixish x86 flavors
  #
+ ifeq ($(OS_ARCH), SCOOS)
+ CPPSRCS               := xptcinvoke_unixish_x86.cpp xptcstubs_unixish_x86.cpp
+ endif
+ ifeq ($(OS_ARCH), OpenUNIX)
+ CPPSRCS               := xptcinvoke_unixish_x86.cpp xptcstubs_unixish_x86.cpp
+ endif
+ 
  ifneq (,$(filter Linux FreeBSD NetBSD OpenBSD BSD_OS,$(OS_ARCH)))
  ifeq (86,$(findstring 86,$(OS_TEST)))
  CPPSRCS               := xptcinvoke_unixish_x86.cpp xptcstubs_unixish_x86.cpp

And:

*** xptc_platforms_unixish_x86.h.0      Tue Oct  2 15:35:31 2001
--- xptc_platforms_unixish_x86.h        Thu Feb  7 14:33:34 2002
***************
*** 131,136 ****
--- 131,142 ----
  #elif defined(__sun__) || defined(__sun)
  #define CFRONT_STYLE_THIS_ADJUST
  
+ #elif defined(SCO)
+ #define CFRONT_STYLE_THIS_ADJUST
+ 
+ #elif defined(UNIXWARE)
+ #define CFRONT_STYLE_THIS_ADJUST
+ 
  #else
  #error "need a platform define if using unixish x86 code"
  #endif

Comment 9

[David Bradley]

Do we want to get the existing patch in, or move this out and get a modified patch??

Comment 10

[David Bradley]

retargetting to post 1.0

Comment 11

[David Bradley]

Moving out to 1.3. If this needs to be in before 1.3 please comment.

Comment 12

[David Bradley]

Moving to 1.4 Alpha

Comment 13

[David Bradley]

Moving out

Comment 14

[David Bradley]

Moving out

Comment 15

[David Bradley]

Moving out