Closed Bug 1201243 Opened 5 years ago Closed 3 months ago

Move preferences code from browser/components/preferences/in-content to /browser/components/preferences/

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox43 --- wontfix
firefox77 --- fixed

People

(Reporter: jaws, Assigned: ntim)

References

Details

Attachments

(2 files)

Now that bug 1140495 is fixed, we can remove the extra nesting of directories here.

applicationManager.js will need to be updated, as well as other files that reference "in-content". A simple MXR search for "in-content" should suffice. We may also be able to update the line for handling old preference URLs in nsBrowserContentHandler.js:handle.
Depends on: 1630039
Depends on: 1626485
Depends on: 1630201

Now that the theme work is out of the way, I think this could be a good first bug (unless you want to work on this). Jared, do you want to mentor this?

It should be a simple hg mv and mass replacing preferences/in-content/ with preferences/ across the tree. The only potential challenge I see are the conflicting containers.js,xhtml files.

Flags: needinfo?(jaws)

ignore-this-changeset

Depends on D72038

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a1739b0379ce
Make browser/components/preferences/in-content top-level and move dialogs to a subdirectory. r=jaws
https://hg.mozilla.org/integration/autoland/rev/3b3fd5447838
Reformat with prettier.
Summary: Move preferences code from browser/components/preferences/in-content to /browser/preferences/ → Move preferences code from browser/components/preferences/in-content to /browser/components/preferences/
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.