1201243 - Move preferences code from browser/components/preferences/in-content to /browser/components/preferences/

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Now that bug 1140495 is fixed, we can remove the extra nesting of directories here.

applicationManager.js will need to be updated, as well as other files that reference "in-content". A simple MXR search for "in-content" should suffice. We may also be able to update the line for handling old preference URLs in nsBrowserContentHandler.js:handle.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This bug will also need to merge the files /browser/themes/*/preferences/preferences.css and /browser/themes/*/preferences/in-content/preferences.css.

Comment 2

[Tim Nguyen :ntim]

Now that the theme work is out of the way, I think this could be a good first bug (unless you want to work on this). Jared, do you want to mentor this?

It should be a simple hg mv and mass replacing preferences/in-content/ with preferences/ across the tree. The only potential challenge I see are the conflicting containers.js,xhtml files.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1201243 - Make browser/components/preferences/in-content top-level and move dialogs to a subdirectory.

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1201243 - Reformat with prettier.

ignore-this-changeset

Depends on D72038

Comment 5

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3b6832ce9fe086746fc089f3621ae991961b8f8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1739b0379ce
Make browser/components/preferences/in-content top-level and move dialogs to a subdirectory. r=jaws
https://hg.mozilla.org/integration/autoland/rev/3b3fd5447838
Reformat with prettier.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a1739b0379ce
https://hg.mozilla.org/mozilla-central/rev/3b3fd5447838