1201345 - Running `make package` in the x86_64 objdir of a universal mac build fails

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

It fails because we use the package-manifest with the #defines for the x86-64 build, which includes jemalloc, but we don't build jemalloc for i386, so we don't have libreplace_jemalloc.dylib:
 14:47:15 INFO - Error: /builds/slave/try-m64-0000000000000000000000/build/src/browser/installer/package-manifest.in:128: File missing in /builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/x86_64/../i386/dist: Nightly.app/Contents/MacOS/libreplace_jemalloc.dylib
14:47:15 INFO - Error: /builds/slave/try-m64-0000000000000000000000/build/src/browser/installer/package-manifest.in:128: Missing file(s): /Nightly.app/Contents/MacOS/libreplace_jemalloc.dylib 

The converse of this is that we're currently building that library for x86-64 but not shipping it in Nightly because we're using the i386 package manifest which doesn't have it.

Comment 1

[(not currently active) Ted Mielczarek]

Try log from my patch that hit this:
https://treeherder.mozilla.org/logviewer.html#?job_id=11021207&repo=try

Comment 2

[(not currently active) Ted Mielczarek]

glandium says bug 762449 will fix this, but that's not riding the trains yet so it's not really safe to land bug 1201224 until that is configured to ride the trains.

Comment 3

[(not currently active) Ted Mielczarek]

glandium clarified: the problem only happens with replace malloc enabled, and replace malloc is not enabled on aurora+, so this should be fine.

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, that fixed it:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=621b6408bdac

Comment 5

[Julien Pagès (:parkouss)]

+1, great work!