Closed Bug 1201352 Opened 10 years ago Closed 4 years ago

dialog announcing restart should offer delay in restarting

Categories

(Firefox :: Settings UI, enhancement)

Product:
Firefox
Component:
Settings UI
Version:
47 Branch
Platform:
Other
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Nick_Levinson, Unassigned)

Details

A "Restart Firefox" dialog says, "Firefox must restart to disable this feature." It offers the Cancel and OK buttons. While "OK" is conventional, in this context it does not tell us that the restart will be immediate, thereby interrupting our work. Various other programs with a similar requirement to restart after changing a setting allow the user to delay restarting, such as so the user can save or copy information. Therefore, this "OK" button should be relabeled "Restart now". A similar dialog may exist for enabling certain features. It should behave the same way. Therefore, its "OK" button should also be relabeled "Restart now". The Cancel button, in my observation so far, reverts the setting. In that case, a user may prefer that there be added a third button, "Restart later", which would not revert the setting but preserve it for use after the next restart. If a user edits the settings in any way in between "Restart later" and the next restart, then "Restart later" would continue to be operative. As a bonus, if the user edits the settings more than once so the net change is no change, a dialog would say so and a need to restart later would disappear, becoming unnecessary. This is in FF 40.0 for openSuse 13.2 Linux.
Restarting FF is not a common action, it's used to finish the install of an add-on or to apply an update. And in these cases in general, the user wants an immediate result. It's really a niche feature for me.
It happened within FF with a change in settings, too. I think they were security/privacy settings. We may want an immediate result, or we may have tabs open and pages loaded and would like a choice. It can take a while to reconstruct all the tabs.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Component: General → Preferences
Resolution: --- → DUPLICATE
This was marked as a duplicate of a bug that has now been resolved, but the issue in this bug remains unresolved (bug 1156176 comment 28). At that bug, it was said that this one should not have been considered a duplicate of that one (bug 1156176 comment 29). So, I'm reopening here, hoping for a patch.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Version: 40 Branch → 47 Branch

Is this still an issue?

Flags: needinfo?(Nick_Levinson)

The main issue is now resolved. What was the "OK" button now says "Restart Firefox now", which gives the needed notice.

My new test: FF 90.0.2 (64-bit) on Fedora 34 Linux (kept evergreen) > Edit > Settings (thus about:preferences) > Privacy & Security > History > Firefox Will (menu already at Never Remember History) > Remember History yielded a dialog titled Restart Firefox and saying "Firefox must restart to disable this feature." with buttons "Cancel" & "Restart Firefox now".

I had also suggested a Restart Later option, but I now assume there was not much interest in implementing that.

So, I'm closing on the basis of the main issue. If Restart Later is desired, please reopen or start a new thread. Thanks.

Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago → 4 years ago
Flags: needinfo?(Nick_Levinson)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.