Remote cppunit test is unable to launch x86 emulator correctly

RESOLVED FIXED in Firefox 44

Status

Testing
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: edgar, Assigned: jdai)

Tracking

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
remotecppunittests doesn't tell mozrunner which kind of arch should be launch, so mozrunner use the default one [2]. We have to find some way to pass the arch information to remotecppunuttests.

[1] https://dxr.mozilla.org/mozilla-central/source/testing/remotecppunittests.py?offset=0#230
[2] https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/runners.py?offset=0#87
(Reporter)

Updated

2 years ago
Blocks: 1192134
(Assignee)

Comment 1

2 years ago
Add try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=59750d419805
(Assignee)

Comment 2

2 years ago
Created attachment 8657680 [details] [diff] [review]
WIP, patch, v1

try looks good:
https://treeherder.allizom.org/#/jobs?repo=try&revision=8ffd6d645a91
(Reporter)

Updated

2 years ago
Depends on: 1188330
(Assignee)

Updated

2 years ago
QA Contact: jdai
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1351a518e72
(Assignee)

Updated

2 years ago
Assignee: nobody → jdai
QA Contact: jdai
Comment hidden (obsolete)
Comment hidden (obsolete)
(Assignee)

Comment 6

2 years ago
Created attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator architecture parameter to cppunit test; r?ahal
Attachment #8664621 - Flags: review?(ahalberstadt)
(Assignee)

Comment 7

2 years ago
Since I can't retrigger failed test, I put 2 try link for you to reference.

Try link:
With x86-kk try error but others are green:
https://treeherder.allizom.org/#/jobs?repo=try&revision=f825cdfbfc3e
Without x86-kk try error:
https://treeherder.allizom.org/#/jobs?repo=try&revision=0b018ffcf7e6
Attachment #8664621 - Flags: review?(ahalberstadt)
Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

https://reviewboard.mozilla.org/r/20017/#review18071

::: testing/remotecppunittests.py:230
(Diff revision 1)
> -
> +        self.add_option("--emulator", action="store",
> +                    type="string", dest = "emulator",

nit: the action, type and dest parameters aren't needed here as those are already the default values.

::: testing/remotecppunittests.py:232
(Diff revision 1)
> +                    help = "Architecture of emulator to use: x86 or arm")

You should add a 'choices' parameter, that way it'll fail fast if someone types something other than 'arm' or 'x86':
https://docs.python.org/2.7/library/argparse.html#choices
(Assignee)

Comment 9

2 years ago
Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator parameter to cppunit test; r?ahal
Attachment #8664621 - Attachment description: MozReview Request: Bug 1201370 - Add emulator architecture parameter to cppunit test; r?ahal → MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test; r?ahal
Attachment #8664621 - Flags: review?(ahalberstadt)
(Assignee)

Comment 10

2 years ago
Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=2415e8e93ae5
Attachment #8664621 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

https://reviewboard.mozilla.org/r/20017/#review18195

Thanks!
(Assignee)

Comment 12

2 years ago
Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator parameter to cppunit test. r=ahal
Attachment #8664621 - Attachment description: MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test; r?ahal → MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal
Attachment #8664621 - Flags: review+ → review?(ahalberstadt)
(Assignee)

Updated

2 years ago
Attachment #8664621 - Flags: review?(ahalberstadt) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 13

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e77b81bc2a7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6e77b81bc2a7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.