1201377 - Sandbox is nuked in the wrong place for content scripts

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Another really stupid bug. It calls us to nuke the content script sandbox whenever we add a listener. The onMessage.addListener call is sufficient to trigger it.

Comment 1

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8656365 [details] [diff] [review]
patch

Review of attachment 8656365 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/test/mochitest/test_sandbox_var.html
@@ +19,5 @@
> +  });
> +}
> +
> +function contentScript()
> +{

{ should move up

@@ +41,5 @@
> +  },
> +};
> +
> +add_task(function* test_contentscript()
> +{

here too

@@ +46,5 @@
> +  let extension = ExtensionTestUtils.loadExtension(extensionData);
> +  yield extension.startup();
> +  info("extension loaded");
> +
> +  yield new Promise(resolve => { setTimeout(resolve, 0); });

I'm not sure why we need this one.

@@ +50,5 @@
> +  yield new Promise(resolve => { setTimeout(resolve, 0); });
> +
> +  let win = window.open();
> +
> +  win.location = "file_contentscript_page1.html";

This file is not in this patch. Make sure you land that patch first that has it :)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8d73d3c3e1

Comment 3

[Carsten Book [:Tomcat]]

sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3416308a1151 since one of this changes caused test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=13682808&repo=mozilla-inbound

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b110d2dd019

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b110d2dd019