1201404 - Stagefright: Implement unit tests

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

There is currently no easy way (that I know of) to test libstagefright, making it difficult to debug and fix issues.

This bug will setup a minimal test suite, which other libstagefright can add to during debugging, fixing, and to later prevent regressions.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1201404-stagefright-mpeg4-minimal-gtests.patch

Minimal gtests that exercise MP4Metadata and MoofParser with an empty stream.
(Other libstagefright bugs will add to these as needed.)

Run with: ./mach gtest stagefright*

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8656421 [details] [diff] [review]
1201404-stagefright-mpeg4-minimal-gtests.patch

Review of attachment 8656421 [details] [diff] [review]:
-----------------------------------------------------------------

Yay tests!

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed25c8322843

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e85c196098

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5e85c196098