1201419 - [NFC] Unable to share contact via NFC

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Alison Shiue]

Attachment: nfc_share_contact.log

Flame-kk 2.5 and Aries 2.5 both have this issue.

STR: 
1. Tap 2 devices to share contact via NFC 

Expected result: 
Show shrinking UI and can share contact via swipe it

Actuak result: 
No shrinking UI

Build Info:
[Flame-kk]
Build ID               20150902150202
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gaia Date              2015-09-02 17:52:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a6786bf8d71d4cf40c3d40e06d8e3c9866863475
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150902.182956
Firmware Date          Wed Sep  2 18:30:06 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20150902203922
Gaia Revision          29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gaia Date              2015-09-02 17:52:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a6786bf8d71d4cf40c3d40e06d8e3c9866863475
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150902.200033
Firmware Date          Wed Sep  2 20:00:41 UTC 2015
Bootloader             s1

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Regression issue

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working 
Device: Flame
BuildID: 20150819054940
Gaia: fa32b801f6d854e846ea8294dc37840450d36c1e
Gecko: 8643f1d9971c76c98bc32a07ae6d3760f3f3a4bb
Version: 43.0a1
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Device: Flame
BuildID: 20150819061537
Gaia: b57de4c493b611dc70c27c7d78445fcb04b1491c
Gecko: 7feeb30abb6856d4176fd0e5eb7b45da18931c49
Version: 43.0a1
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working Gaia First Broken Gecko - no repro
Gaia: fa32b801f6d854e846ea8294dc37840450d36c1e
Gecko: 7feeb30abb6856d4176fd0e5eb7b45da18931c49

Last Working Gecko First Broken Gaia - repro
Gaia: b57de4c493b611dc70c27c7d78445fcb04b1491c
Gecko: 8643f1d9971c76c98bc32a07ae6d3760f3f3a4bb

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/fa32b801f6d854e846ea8294dc37840450d36c1e...b57de4c493b611dc70c27c7d78445fcb04b1491c

Caused by changes made in Bug 1183727.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Borja this issue seems to have been caused by the changes in bug 1183727.  Can you please take a look?

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Functional regression

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1201419.nfc.contacts > mozilla-b2g:master

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8657895 [details] [review]
[gaia] ferjm:bug1201419.nfc.contacts > mozilla-b2g:master

Unit tests for nfc are failing right now with this patch, probably we will need to update the code to get the nfc loaded too.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8657895 [details] [review]
[gaia] ferjm:bug1201419.nfc.contacts > mozilla-b2g:master

Thanks for fixing the unit tests.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/94506235e9e7765a69628aeb13a6581ca52cdbdd

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: User can be able to share contact via NFC, it shows shrinking UI.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10

Note:
The sharing contact can't be imported successfully now.


Device: Flame KK 2.5 (Pass)
Build ID               20150909150223
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150909.185733
Firmware Date          Wed Sep  9 18:57:43 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150909215153
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150909.211310
Firmware Date          Wed Sep  9 21:13:17 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp