Closed Bug 1201438 Opened 5 years ago Closed 4 years ago

Flash videos in 64 bit Dev Edition builds are playing black (with sound)

Categories

(Core :: Security: Process Sandboxing, defect)

42 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox41 --- unaffected
firefox42 + fixed
firefox43 + fixed

People

(Reporter: caspy77, Assigned: bobowen)

References

Details

(Keywords: regression)

Attachments

(1 file)

In the last day there have been two reddit posts indicating that their Flash videos in Dev Edition 64 bit builds are playing black while the sound continues to play.

https://www.reddit.com/r/firefox/comments/3jcmqu/firefox_dev_edition_videoplayback_only_with_flash/
https://www.reddit.com/r/firefox/comments/3jgfuw/firefox_developers_edition_sudden_flash_problem/
A 3rd commenter indicates they are experiencing the same issue.

It's indicated that it started in the last day or two.

I'll ask them if they will CC to this bug.

This may be from bug 1185532
Alice, would you look for a regression range for this?
Thanks.
Flags: needinfo?(alice0775)
Version: unspecified → 42 Branch
Could you provide a detailed STR?
Flags: needinfo?(alice0775)
I have the same issue as this with the same version of Firefox on Windows 10. The steps I take is:
Load Firefox in Multi-Process Mode.
Go to a website that uses flash video (Example: www.twitch.tv)
Try to play the video.
The audio stream plays but no video plays.
If I disable multi-process mode then the flash video plays as it should and this issue does not happen.
And I can reproduce this issue on Nightly(NIGHTLY_BUILD) with following config.
security.sandbox.content.level=0
To reproduce see Arron's comment. I am having the same issue. I am also on Windows 10, Firefox Dev Edition (V42) 64-bit, e10s enabled.
Any website that has flash playback is "broken" for me. I can hear the sound and get the soundindicator icon on the tab, but the video is just black (most prominent example: twitch.tv)
Can also confirm that this happens (sound plays but flash video is blank) when Multi-Process Mode is enabled and does not occur when Multi-Process Mode is not enabled. This is a fairly recent bug and first appeared in firefox42.
I think this is happening for windowless plugins as the duplication of the handle for the surface is failing.

That's because the content process isn't sandboxed, so the chrome process doesn't recognise it as a valid process for handle duplication.
Assignee: nobody → bobowen.code
Duplicate of this bug: 1202255
Bug 1201438: Add non-sandboxed Windows content processes as target peers for handle duplication. r?bbondy
Attachment #8657690 - Flags: review?(netzen)
Comment on attachment 8657690 [details]
MozReview Request: Bug 1201438: Add non-sandboxed Windows content processes as target peers for handle duplication. r?bbondy

Looks good, thanks!
Attachment #8657690 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/d56cd50e1461
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8657690 [details]
MozReview Request: Bug 1201438: Add non-sandboxed Windows content processes as target peers for handle duplication. r?bbondy

Note: follow-up patch from comment 15 to fix build with disabled sandbox, should be uplifted as well.

Approval Request Comment
[Feature/regressing bug #]:
Bug 1185532

[User impact if declined]:
64-bit windowless flash content on Aurora will continue to play with no video.

[Describe test coverage new/current, TreeHerder]:
No in tree flash coverage, but tested on twitch.tv manually.

[Risks and why]:
Low to medium: not a totally trivial patch, but only adds non-sandboxed processes to a list for handle duplication using existing Chromium sandbox functionality.
The list will only be used for 64-bit flash.

[String/UUID change made/needed]:
None
Attachment #8657690 - Flags: approval-mozilla-aurora?
Comment on attachment 8657690 [details]
MozReview Request: Bug 1201438: Add non-sandboxed Windows content processes as target peers for handle duplication. r?bbondy

Let's see how it goes.
Attachment #8657690 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
this cause conflicts when uplifting

Tomcats-MacBook-Pro:mozilla-central Tomcat$ hg graft --edit -r 41005726fcc1
grafting 298015:41005726fcc1 "Bug 1201438 - Fixup for builds with disabled sandbox."
merging ipc/glue/GeckoChildProcessHost.cpp
3 files to edit
merging ipc/glue/GeckoChildProcessHost.cpp failed!

could you take a look, thanks!
Flags: needinfo?(bobowen.code)
Flags: needinfo?(bobowen.code)
Duplicate of this bug: 1200440
You need to log in before you can comment on or make changes to this bug.