1201446 - Don't expose some websocket reasons to Loop's view code - use the failure details instead

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

We're currently exposing some of the websocket failures to the view code. We need to clean this up fully in bug 1124384, however, for now, I want to cut down the some of the existing exposure - namely the websocket reasons for when the user is unavailable.

This makes writing tests for bug 1184933 simpler, as we'll have less codes that are duplicated/exposed to the view code.

Comment 1

[Mark Banner (:standard8)]

Attachment: Don't expose websocket reasons to the view code where we have a specific failure detail available.

Implements what I need for comment 0, and also tidies up some of the test code to use the newer style formatting.

Split out from bug 1184933 to make those patches smaller.

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8656485 [details] [diff] [review]
Don't expose websocket reasons to the view code where we have a specific failure detail available.

Review of attachment 8656485 [details] [diff] [review]:
-----------------------------------------------------------------

r=Mardak

::: browser/components/loop/test/shared/conversationStore_test.js
@@ +1196,5 @@
> +
> +        it("should dispatch a connection failure action", function() {
> +          store.setStoreState({
> +            outgoing: true
> +          });

You can move the setStoreState into a beforeEach for these 3 tests.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/93878395a38d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93878395a38d