1201474 - Keyword bookmark searches modify/create breaks a lot

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[buttafoo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826023504

Steps to reproduce:

Option 1)
   * Click "Add keyword for this search..."
   * add a keyword
   * Try to use it. Does not work.

Option 2)
   * Click Bookmarks | Show All Bookmarks
   * Edit one of the keyword search bookmarks
   * This bookmark is now broken. The keyword disappears and cannot be re-added


Actual results:

Editing an existing keyword bookmark causes it to stop functioning. Creating a new one does not work


Expected results:

Keyword bookmarks should work.

Comment 1

[Springtime]

Can confirm Option 1 using the latest Firefox Dev build. Keywords added using that method aren't added to the bookmark.

I've also found that adding a bookmark manually and replacing the URL with a custom search (eg: example.com?q=%s) and adding a keyword fails to save the keyword.

Can't reproduce Option 2. Editing an existing keyword bookmark by changing either the name or keyword still works (except for one bookmark I'm having issues with mentioned in Bug 1188619 which isn't saving the keyword at all).

Comment 2

[JRobert]

I can confirm both options in Firefox 42.0, MacOS 10.10.5.
- Create a new bookmark with keyword: Keyword field is not saved, appears empty on subsequent examination.
- Edit an existing bookmark's keyword: (ditto).

Comment 3

[:Gijs (he/him)]

Is this still an issue? I'm fairly sure both of these are fixed in Firefox 44. If you're still seeing issues, can you retest on a clear profile ( https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles ) ?

Comment 4

[Marco Bonardo [:mak]]

I suspect it's bug 1150678.

Comment 5

[buttafoo]

Thanks for looking into this.

It does *not* work if I use my regular profile. Option 1 just spinny-wheels until I kill -9 firefox. Option 2 exhibits the same behavior as originally described in this bug's description.

If I create a new profile, Option 1 does work. I put it in a new folder called Bookmarks Menu | QuickSearches. 

However, Option 2 is only partially fixed: If I Show All Bookmarks and edit the new one by, say, changing the url, close out the window and use the quick search, I get the original url, not the new one. If I go back into Show All Bookmarks, edit the same bookmark, I see the keyword has vanished. I can now re-enter the keyword and then the new url works when I use the quicksearch in the location bar.

So basically, editing an existing keyword search is a two-step affair:
1) Change the url - exit bookmarks UI
2) Re-add the keyword - exit bookmarks UI


Firefox 44.0.2 on Mac OS 10.10.5

Comment 6

[Springtime]

Had to edit the places.sqlite database manually using these [1] steps to delete the old keywords, since Firefox (up to v46 now) hasn't properly been removing previously saved keywords from deleted bookmarks.

[1] http://forums.mozillazine.org/viewtopic.php?f=9&t=2944961&p=14512685#p14512685

Comment 7

[Rajesh Krishnan]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

I can confirm #2.  I cannot assign a persistent keyword to a search after clicking on Bookmarks in menu bar, right clicking on my saved search keyword, putting in keyword then clicking Save.  It disappears each time.

Comment 8

[Gonzalo HIGUERA DÍAZ]

Tests conducted using clean profiles under macOS 10.12.2 running:

a) Firefox 50.1.0 build 20161208153507 release; UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:50.0) Gecko/20100101 Firefox/50.0

b) Firefox 51.0b13 build 20170109165508 beta; UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:51.0) Gecko/20100101 Firefox/51.0

c) Firefox 53.0a1 build 20170111030235 nightly; UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0


Regarding Option 1, it works for me in all three cases.

Regarding Option 2, for case a) I experience the behaviour described in comment #5: if I edit the URL/location of a bookmark its keyword disappears but the keyword search continues working, pointing to the original URL; and if I then create a new bookmark with the unedited URL/location, the keyword reappears on that newly created bookmark. However, this behaviour seems fixed for cases b) and c) (i.e. when changing a bookmark's URL/location, the keyword is preserved).

Comment 9

[Marco Bonardo [:mak]]

hm, somehow bugzilla put wrong edits, or I set them in the wrong tab :(

I think we fixed this bug some time ago.