Closed Bug 1201504 Opened 6 years ago Closed 6 years ago
Open into a private browsing tab from a button on the tab tray
48 bytes, text/x-github-pull-request
|Details | Review|
86 bytes, text/plain
176 bytes, text/plain
We will need some UI for starting a private tab vs a normal tab from the tab tray. This bug tracks: - Integrating the UI for the method of opening a private tab - Making modifications to the existing normal tab button if needed - Creating a WKWebView instance that supports data-less browsing
I remember seeing some UI for initial thoughts around what visual cues we want to do for private browsing. Do we have any designs for how we want to open a private tab?
Do you have the asset for the goggles?
First pass at private browsing UI in the tab tray and managing private/normal tabs.
I'm currently working on some tests and ironing out a couple of things if you want to hold off on this but there's probably enough changes in here to start some discussion.
Comment on attachment 8661952 [details] [review] https://github.com/mozilla/firefox-ios/pull/1076 Looks good. Nice series of commits!
Attachment #8661952 - Flags: review?(bnicholson) → review+
Fixed up the UI nits with new assets and implemented :dusek's accessibility feedback.
Attachment #8662524 - Flags: feedback?(bnicholson)
Comment on attachment 8662524 [details] https://github.com/mozilla/firefox-ios/commit/c17a27b15f8e960cf3019dacd93e185db7be8064 LGTM!
Attachment #8662524 - Flags: feedback?(bnicholson) → feedback+
Eventually this will land.. I swear.. Added two additional commits: https://github.com/mozilla/firefox-ios/commit/5a627eca375411cb41d58f2bf130dd5606eae3e9 https://github.com/mozilla/firefox-ios/commit/6fb0ec79f32394a07d9345eb1c0a27404940170e The first resolves an issue :darrin found where the tab count was not updating correctly when opening a private tab. updateTabCount gets called twice and the previous animation doesn't get cancelled which causes the tab button to show the normal tab count in place of the private one. The second resolves broken tests from that change to the accessibility label for toggling private mode. Also makes sure that we only avoid setting the count if we cancel the animation for updateTabCount, not avoid attaching the accessibility label.
Attachment #8662615 - Flags: review?(bnicholson)
Attachment #8662615 - Flags: review?(bnicholson) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8661952 - Flags: ui-review?(dhenein) → ui-review+
Verifying as fixed on the current TestFlight build (1104)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.