Closed Bug 1201567 Opened 9 years ago Closed 9 years ago

[Settings] Convert SimPin dialog switch to use web components

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

[gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review 
      No description provided.
Comment on attachment 8656635 [details] [review]
[gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master

Hi Fred - 

Moving this to a new bug. I've addressed your review comments, and added a comment about why I think breaking out that change case into a new function is good.

Please take a look if you get a chance, thanks!
Attachment #8656635 - Flags: review?(gasolin)
Comment on attachment 8656635 [details] [review]
[gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master

good work!

Please check the comment in github before merge.
Attachment #8656635 - Flags: review?(gasolin) → review+
Thank you for the review. In master: https://github.com/mozilla-b2g/gaia/commit/e6a02ff3f340c03ada25b94d5ef5a01568b148bb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: