Status
People
(Reporter: kgrandon, Assigned: kgrandon)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
46 bytes,
text/x-github-pull-request
|
gasolin
:
review+
|
Details | Review | Splinter Review |
| Comment hidden (empty) |
|
||
Comment 1•4 years ago
|
||
Created attachment 8656635 [details] [review] [gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master
|
(Assignee) | |
Comment 2•4 years ago
|
||
Comment on attachment 8656635 [details] [review] [gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master Hi Fred - Moving this to a new bug. I've addressed your review comments, and added a comment about why I think breaking out that change case into a new function is good. Please take a look if you get a chance, thanks!
Attachment #8656635 -
Flags: review?(gasolin)
|
||
Comment 3•4 years ago
|
||
Comment on attachment 8656635 [details] [review] [gaia] KevinGrandon:bug_1201567_settings_simpin_panel_switch > mozilla-b2g:master good work! Please check the comment in github before merge.
Attachment #8656635 -
Flags: review?(gasolin) → review+
|
|
(Assignee) | |
Comment 4•4 years ago
|
||
Thank you for the review. In master: https://github.com/mozilla-b2g/gaia/commit/e6a02ff3f340c03ada25b94d5ef5a01568b148bb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.