1201619 - Fix some tab tray dimen issues

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

antlam mentioned that the new tabs tray didn't look quite right on the N5 - the previews looked too small.  Whilst investigating I noticed a slight calculation issue on the sw400dp values too.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1201619 - Fix some tab tray dimen issues; r?mcomella

Bug 1201619 - Fix some tab tray dimen issues; r?mcomella

not a very good bug title, but was just going through some issues with antlam and these are such small changes that they really don't deserve their own bug.  Anyway, I've introduced a new sw360dp folder to target the n5 and similar phones.  I'm worried that we're going to have a load of folders hanging around to target different phone SW values, a recycler view will be able to automatically determine the best dimens for the tabs previews, so we should get that looked at soon imo.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8657031 [details]
MozReview Request: Bug 1201619 - Fix some tab tray dimen issues; r?mcomella

https://reviewboard.mozilla.org/r/18277/#review16405

> I'm worried that we're going to have a load of folders hanging around to target different phone SW values, a recycler view will be able to automatically determine the best dimens for the tabs previews, so we should get that looked at soon imo.

Agreed.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fecf8cae8265

Comment 4

[Martyn Haigh (:mhaigh)]

RecyclerView should fix the issue of having loads of dimens files around as we should be able to write a LayoutManager to work out optimum sizes based on device metrics - https://bugzilla.mozilla.org/show_bug.cgi?id=1116415

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fecf8cae8265