Closed Bug 1201619 Opened 6 years ago Closed 6 years ago

Fix some tab tray dimen issues

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: mhaigh, Assigned: mhaigh)

Details

Attachments

(1 file)

antlam mentioned that the new tabs tray didn't look quite right on the N5 - the previews looked too small.  Whilst investigating I noticed a slight calculation issue on the sw400dp values too.
Bug 1201619 - Fix some tab tray dimen issues; r?mcomella

not a very good bug title, but was just going through some issues with antlam and these are such small changes that they really don't deserve their own bug.  Anyway, I've introduced a new sw360dp folder to target the n5 and similar phones.  I'm worried that we're going to have a load of folders hanging around to target different phone SW values, a recycler view will be able to automatically determine the best dimens for the tabs previews, so we should get that looked at soon imo.
Attachment #8657031 - Flags: review?(michael.l.comella)
Comment on attachment 8657031 [details]
MozReview Request: Bug 1201619 - Fix some tab tray dimen issues; r?mcomella

https://reviewboard.mozilla.org/r/18277/#review16405

> I'm worried that we're going to have a load of folders hanging around to target different phone SW values, a recycler view will be able to automatically determine the best dimens for the tabs previews, so we should get that looked at soon imo.

Agreed.
Attachment #8657031 - Flags: review?(michael.l.comella) → review+
RecyclerView should fix the issue of having loads of dimens files around as we should be able to write a LayoutManager to work out optimum sizes based on device metrics - https://bugzilla.mozilla.org/show_bug.cgi?id=1116415
https://hg.mozilla.org/mozilla-central/rev/fecf8cae8265
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.