Closed
Bug 1201692
Opened 7 years ago
Closed 7 years ago
ExplicitChildIterator::Seek leads to O(N^2) behavior during frame reconstruction
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(2 files)
This is basically a regression from bug 653881. I should have caught it then in review... The old seek() call on the ChildIterator in FindInsertionPrevSibling was O(1) in the common case. But the new Seek() call on ExplicitChildIterator is O(N) in all cases, since it always does a walk along all the kids until it gets to the one we want. We should be able to fast-path at least the common case here, I'd think: that aChildToFind is a child of mParent. In that case, can't we just set mChild to aChildToFind and return?
Flags: needinfo?(mrbkap)
![]() |
Assignee | |
Comment 1•7 years ago
|
||
![]() |
Assignee | |
Comment 2•7 years ago
|
||
This speeds up the testcase by 30% or so
Attachment #8656961 -
Flags: review?(wchen)
![]() |
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•7 years ago
|
||
Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eabce5e52ac looks good to me.
Updated•7 years ago
|
Attachment #8656961 -
Flags: review?(wchen) → review+
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1e45a92a376
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•7 years ago
|
Flags: needinfo?(mrbkap)
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•