1201693 - moz.build metadata entry in js/src/moz.build mentions deleted file

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I'm trying to land a test to keep patterns in Files() contexts from getting stale and found one in js/src/moz.build -- the pattern 'jsreflect.*' corresponds to files since deleted.

I have a patch to remove the pattern, but if this functionality has moved somewhere else we should take that into account.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier

Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8656816 [details]
MozReview Request: Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier

https://reviewboard.mozilla.org/r/18249/#review16395

Thanks! Indeed we now duplicate information between the actual position of the file and the meta-data information in the moz.build file. I guess we're not the only component in which this will happen, so we might need an automated verification system, at some point.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Oh, I may have read comment 0 too quickly: so you're actually working on that verification system? That's great!

Also, for the record: jsreflect.* have been moved into the builtin/ directory, which also has a metadata line, and all files in builtin/ have the same component as the former jsreflect.* files, so we're good here.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/314e201aa2d7

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Thanks for the review. Nothing fancy, just a check test to fail when this would happen.

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5da1602564

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d72a38217499

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d72a38217499