Closed Bug 1201693 Opened 5 years ago Closed 5 years ago
.build metadata entry in js/src/moz .build mentions deleted file
MozReview Request: Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier
40 bytes, text/x-review-board-request
I'm trying to land a test to keep patterns in Files() contexts from getting stale and found one in js/src/moz.build -- the pattern 'jsreflect.*' corresponds to files since deleted. I have a patch to remove the pattern, but if this functionality has moved somewhere else we should take that into account.
Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier
Attachment #8656816 - Flags: review?(benj)
Attachment #8656816 - Flags: review?(benj) → review+
Comment on attachment 8656816 [details] MozReview Request: Bug 1201693 - Remove Files pattern in js/src/moz.build corresponding to a deleted file. r=bbouvier https://reviewboard.mozilla.org/r/18249/#review16395 Thanks! Indeed we now duplicate information between the actual position of the file and the meta-data information in the moz.build file. I guess we're not the only component in which this will happen, so we might need an automated verification system, at some point.
Oh, I may have read comment 0 too quickly: so you're actually working on that verification system? That's great! Also, for the record: jsreflect.* have been moved into the builtin/ directory, which also has a metadata line, and all files in builtin/ have the same component as the former jsreflect.* files, so we're good here.
Thanks for the review. Nothing fancy, just a check test to fail when this would happen.
You need to log in before you can comment on or make changes to this bug.