1201705 - [Music][NGA] Integration test for playlist tab in NGA (part 2)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

This is part 2 of bug 1195982 - test the playlist tab (test do exist, probably need to be fixed for NGA)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 8656905 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master

There will be a part 3 coming for the most played playlist. When I get it to work.
This is Part 1 and part 2. Part 1 is a sample file binary change same as in OGA.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8656905 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master

LGTM. Still don't know why incrementing play count isn't working from tests.

Comment 4

[Hubert Figuiere [:hub]]

I'll figure it out eventually.

Comment 5

[Hubert Figuiere [:hub]]

First PR merged
https://github.com/mozilla-b2g/gaia/commit/2d370fa35c1a0ee2a637e3772c0843586a5f96c9

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 8664987 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master

On top of your patch, even though I'm not sure it requires it.

This is the last iteration of the patch, more robust than before.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8664987 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master

LGTM

Comment 9

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/1b0020111cf8882e725de8b4095649fb842db86a