Closed Bug 1201705 Opened 8 years ago Closed 8 years ago

[Music][NGA] Integration test for playlist tab in NGA (part 2)

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S8 (02Oct)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(2 files)

[gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
[gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
This is part 2 of bug 1195982 - test the playlist tab (test do exist, probably need to be fixed for NGA)
Assignee: nobody → hub
Blocks: 1196438
Depends on: 1201702
Blocks: 1193835
No longer blocks: 1196438
Comment on attachment 8656905 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master

There will be a part 3 coming for the most played playlist. When I get it to work.
This is Part 1 and part 2. Part 1 is a sample file binary change same as in OGA.
Attachment #8656905 - Flags: review?(jdarcangelo)
Comment on attachment 8656905 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test > mozilla-b2g:master

LGTM. Still don't know why incrementing play count isn't working from tests.
Attachment #8656905 - Flags: review?(jdarcangelo) → review+
I'll figure it out eventually.
Status: NEW → ASSIGNED
Target Milestone: --- → FxOS-S8 (02Oct)
Comment on attachment 8664987 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master

On top of your patch, even though I'm not sure it requires it.

This is the last iteration of the patch, more robust than before.
Attachment #8664987 - Flags: review?(jdarcangelo)
Comment on attachment 8664987 [details] [review]
[gaia] hfiguiere:bug1201705-playlist-tab-test-part2 > mozilla-b2g:master

LGTM
Attachment #8664987 - Flags: review?(jdarcangelo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/1b0020111cf8882e725de8b4095649fb842db86a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.