Update Google icon for Search

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: antlam, Assigned: mcomella)

Tracking

unspecified
Firefox 44
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified, firefox43 verified, firefox44 verified)

Details

Attachments

(3 attachments)

Google got a new logo, so I'll need to make a new asset and OK it with them so we can get it updated in our UI.

Will be seen in Quick search bar, Search settings, Awesomescreen.

Updated

4 years ago
Blocks: 1200726
Anthony, can you coordinate with Joanne as well? I've asked if we can get the source assets from Google in 1200726, and it'd be good to understand what resolution(s) we'll need.
Isn't this just a dupe of Bug 1200726? The icon we show in the UI *is* the favicon from the searchplugin.
We typically ask the provider for icons of all sizes needed (e.g. we ask them to supply the source). It's not our brand, and when we've modified or used favicons direct from websites in the past, it hasn't always met their guidelines. 1200726 is for desktop, specifically, and I'm all for consolidating everything in one bug.

(In reply to Richard Newman [:rnewman] from comment #2)
> Isn't this just a dupe of Bug 1200726? The icon we show in the UI *is* the
> favicon from the searchplugin.
(In reply to Kev Needham [:kev] from comment #1)
> Anthony, can you coordinate with Joanne as well? I've asked if we can get
> the source assets from Google in 1200726, and it'd be good to understand
> what resolution(s) we'll need.

Yep, I did this last time with Joanne and have CC'd her here as well. I'm just having trouble locating their new brand assets (not sure they've even posted any externally yet) so I wanted to just file this first.
Tested with:
Device: Moto X (Android 4.4)
Build: Firefox for Android  43.0a1 (2015-09-06)

Google search icon appears blank, but after turning on search suggestions, the favicon is displayed.
(In reply to Teodora Vermesan (:TeoVermesan) from comment #5)
> Created attachment 8657755 [details]
> Screenshot from 2015-09-07 13_29_06.png
> 
> Tested with:
> Device: Moto X (Android 4.4)
> Build: Firefox for Android  43.0a1 (2015-09-06)
> 
> Google search icon appears blank, but after turning on search suggestions,
> the favicon is displayed.

Hey Teo, 

I think that's another bug. This is just for replacing (and thus, updating) to use their new logo.
I found them! these are for Android.

NI-ing mcomella to update since he touched this last :)
Flags: needinfo?(michael.l.comella)
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella)
Bug 1201770 - Update google search engine icon. r=margaret

I added a wiki page to note how to do this in the future:
  https://wiki.mozilla.org/Mobile/Fennec/Android/Updating_search_engine_icons
Attachment #8674384 - Flags: review?(margaret.leibovic)
Comment on attachment 8674384 [details]
MozReview Request: Bug 1201770 - Update google search engine icon. r=margaret

https://reviewboard.mozilla.org/r/22219/#review19829

Rubber stamp, assuming approval from Anthony/Joanne/Kev.
Attachment #8674384 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8674384 [details]
MozReview Request: Bug 1201770 - Update google search engine icon. r=margaret

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Users will not have the latest Google search logo with the built-in google search engine.

[Describe test coverage new/current, TreeHerder]: Tested locally.
[Risks and why]: Low – we're replacing a base64-encoded asset. Worst case, the asset is invalid and Google does not show up.

[String/UUID change made/needed]: None
Attachment #8674384 - Flags: approval-mozilla-beta?
Attachment #8674384 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d458bec46d02
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8674384 [details]
MozReview Request: Bug 1201770 - Update google search engine icon. r=margaret

Sure, taking it. Not much risk. Should be in 42 beta 8.
Attachment #8674384 - Flags: approval-mozilla-beta?
Attachment #8674384 - Flags: approval-mozilla-beta+
Attachment #8674384 - Flags: approval-mozilla-aurora?
Attachment #8674384 - Flags: approval-mozilla-aurora+

Comment 16

4 years ago
Verified as fixed on Firefox 42 Beta 8, latest Aurora and Nightly
You need to log in before you can comment on or make changes to this bug.