Closed Bug 1201792 Opened 5 years ago Closed 5 years ago

s/MOZ_JEMALLOC3/MOZ_JEMALLOC4/

Categories

(Core :: Memory Allocator, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Because things are already confusing between mozjemalloc and jemalloc, let's not add more confusion with the fact that MOZ_JEMALLOC3 now means jemalloc 4.
Attachment #8656970 - Flags: review?(n.nethercote)
Comment on attachment 8656970 [details] [diff] [review]
s/MOZ_JEMALLOC3/MOZ_JEMALLOC4/

Review of attachment 8656970 [details] [diff] [review]:
-----------------------------------------------------------------

I trust you used an appropriate grep invocation (or similar) to find all the occurrences.
Attachment #8656970 - Flags: review?(n.nethercote) → review+
(In reply to Nicholas Nethercote [:njn] from comment #2)
> Comment on attachment 8656970 [details] [diff] [review]
> s/MOZ_JEMALLOC3/MOZ_JEMALLOC4/
> 
> Review of attachment 8656970 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I trust you used an appropriate grep invocation (or similar) to find all the
> occurrences.

Indeed, the patch was generated with:
git grep -l MOZ_JEMALLOC3 | xargs sed -i s/MOZ_JEMALLOC3/MOZ_JEMALLOC4/
> git grep -l MOZ_JEMALLOC3 | xargs sed -i s/MOZ_JEMALLOC3/MOZ_JEMALLOC4/

Appending a 'g' on the sed expression would be even safer :)
I cheated, because I first looked at the output of git grep MOZ_JEMALLOC3 and saw there were no more than one per line. :)
https://hg.mozilla.org/mozilla-central/rev/2e49287be6e4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.