1201858 - Add languages-provided.ab-CD.speech-data validation

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Staś Małolepszy :stas]

In bug 1178288 we're adding speech recognition models to langpacks.  This requires changes to the langpack manifests.  In particular, each language entry can now optionally have a 'speech-data' property:

"languages-provided": {
  "fr": {
    ...
    "speech-data": [
      "/fr/speech-data/feat.params",
      "/fr/speech-data/fr.dic",
      "/fr/speech-data/fr.dic.dmp",
      "/fr/speech-data/mdef",
      "/fr/speech-data/means",
      "/fr/speech-data/mixture_weights",
      "/fr/speech-data/noisedict",
      "/fr/speech-data/sendump",
      "/fr/speech-data/transition_matrices",
      "/fr/speech-data/variances"
    ]
  }
}

The field is optional and if present, must be an array of strings.

Can you please add this rule to the appvalidator?

Comment 1

[Staś Małolepszy :stas]

Attachment: Pull request

Here's my attempt.  I'm not quite sure how to add a test for this.  Can you give me some pointers?

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8657078 [details] [review]
Pull request

Mat, I've added tests for speech-data to the pull request. Can you review this?

Comment 3

[Mathieu Pillard [:mat]]

https://github.com/mozilla/app-validator/commit/fe85a97294bb9c84c10b81847fea08e7420f6481
https://github.com/mozilla/zamboni/commit/1f4aa85fcaba35a3d7e43c953017d6858d86a691

Will land on dev in a few minutes, on stage later this week, in prod next Tuesday.

Comment 4

[Staś Małolepszy :stas]

Thanks for the help, closing as fixed.

Comment 5

[Victor Carciu]

Can you please add somt STRs to this bug or mark it as [qa-] ?