1201861 - bbb needs to be able to completely ignore builders, not just disallow them and cancel their tasks

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

This came up in setting up a dev environment for the Buildbot Bridge, which is set-up to use the same provisioner/worker types, but supposed to be restricted to one branch (Alder). In an attempt to make this happen, I made the production instance allow any builders _except_ Alder, which actually caused it to pick up Tasks for Alder and cancel them. This is hardly surprising in retrospect, because allowed_builders was designed originally as a security protection.

Rather than overloading that, we should have ignore_builders to completely ignore builders, and then do additional processing (like allowed_builders) if we get by that filter.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Add support for fully ignoring builders (on top of disallowing others completely)

Comment 2

[[e-mail] (:bhearsum)]

Attachment: add ignored_builders to bbb configs

So the way this works with the new patch, is that tasks with a builder name that match an ignored_builders pattern don't get processed at all (ie, no cancelling). If they make it past that filter, allowed_builders is applied as before - if the task's builder name doesn't match an allowed pattern, it will be cancelled. This is getting reworked as restricted_builders in bug 1196407, but I need to keep allowed_builders for now to finish testing some existing patches in dev.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8657098 [details] [review]
Add support for fully ignoring builders (on top of disallowing others completely)

I landed this, and backported to make a 1.3.1 (because I need it on dev+prod).

Comment 4

[[e-mail] (:bhearsum)]

This is working well in dev and prod.