1201877 - Extensions download paths need an Etag and CORS

Status: RESOLVED FIXED

(Cloud Services :: Operations: Marketplace, task)

Description

[Mathieu Pillard [:mat]]

We have the following in our marketplace.conf:

    location <%= netapp_root %>/shared_storage/signed_apps/ {
        internal;
        add_header Etag $upstream_http_etag;
        add_header Access-Control-Allow-Origin $upstream_http_access_control_allow_origin;
        alias <%= netapp_root %>/shared_storage/signed_apps/;
    }

The same thing - particularly the Etag and Access-Control-Allow-Origin bits - are needed for extensions, both signed and unsigned (we don't have reviewer-signed extensions yet, at the moment we let reviewers download an unsigned file instead). The paths we currently use should be <%= netapp_root %>/files/extensions-signed and <%= netapp_root %>/files/extensions , I think.

Comment 1

[Mathieu Pillard [:mat]]

Note: https://bugzilla.mozilla.org/show_bug.cgi?id=1201888, which should land this week, change the path to <%= netapp_root %>/shared_storage/signed-extensions/ and <%= netapp_root %>/shared_storage/extensions/. So please use those paths instead of the ones from comment 0.

Comment 2

[Jason Thomas [:jason]]

Added to nginx config:

https://github.com/mozilla-services/svcops-puppet/commit/99d1382cb4958339558760a49dc67e8591414ec8

https://github.com/mozilla-services/puppet-config/commit/0ccbdfa0de05454bf7f505a8bd075801c59e93d2