1201902 - Feedback link in conversation window should point to a different URL

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

We should be able to separate feedback received from users selecting the "Help" option par of the gear menu in the conversation window when compared to feedback submitted as part of the NPS link displayed at the end of the first call or every 6 months (bug 1171415).

To allow that the "Help" option par of the gear menu in the conversation window should point to a different survey URL.

Comment 1

[Romain Testard [:RT]]

Gareth, could you please create a replica to the current in-product survey and provide us the link?
We can then work with Fabio and Natalie to determine if there is a reason why taht survey should be different.
Also separate question - does surveygizmo allow identifying/filtering users submitting multiple answers? (cookies...)

Comment 2

[Gareth Cull [:garethc]]

(In reply to Romain Testard [:RT] from comment #1)
> Gareth, could you please create a replica to the current in-product survey
> and provide us the link?

Hey Romain,

On hello.firefox.com conversation pages, we prompted a survey when a link clicker clicked on a "?" and landed on a SUMO page. Maybe we could tweak this survey?

http://www.surveygizmo.com/collab/2152768/Firefox-Hello-Customer-Survey

> Also separate question - does surveygizmo allow identifying/filtering users
> submitting multiple answers? (cookies...)

Yes. It appears we can set this up in SurveyGizmo as per this article:
http://help.surveygizmo.com/help/article/link/duplicate-protection

Comment 3

[Romain Testard [:RT]]

(In reply to Gareth Cull [:garethc] from comment #2)
> (In reply to Romain Testard [:RT] from comment #1)
> > Gareth, could you please create a replica to the current in-product survey
> > and provide us the link?
> 
> Hey Romain,
> 
> On hello.firefox.com conversation pages, we prompted a survey when a link
> clicker clicked on a "?" and landed on a SUMO page. Maybe we could tweak
> this survey?
> 
> http://www.surveygizmo.com/collab/2152768/Firefox-Hello-Customer-Survey

Great idea, it looks like what we need.  Given that "?" clickers will be coming from the standalone link clicker UI we definitely need a different form to be able to identify user types but the questions there look generic enough to be applicable for this bug. Could you just create a copy of that form?

> 
> > Also separate question - does surveygizmo allow identifying/filtering users
> > submitting multiple answers? (cookies...)
> 
> Yes. It appears we can set this up in SurveyGizmo as per this article:
> http://help.surveygizmo.com/help/article/link/duplicate-protection
Awesome, I think we should enable cookie-based duplicate protection on this form to avoid SPAM issues.

Comment 4

[:shell escalante]

have RT update User Story for feedback...

Comment 5

[Romain Testard [:RT]]

Pending URL from Gareth, adding NI.

Comment 6

[Gareth Cull [:garethc]]

Here's the link. Let me know if this looks good. I've updated it to use the Hello Survey Template.

http://www.surveygizmo.com/s3/2319863/d2b7dc4b5687

Comment 7

[Romain Testard [:RT]]

Looks good, thanks!

Comment 8

[Mark Banner (:standard8)]

What needs doing here:

- File a clone of bug 1186373 asking for a new redirect, e.g. https://www.mozilla.org/firefox/hello/feedbacksurvey/ -> http://www.surveygizmo.com/s3/2319863/d2b7dc4b5687

- Create a new pref, e.g. loop.feedback.manualFormURL with the mozilla.org url.

- Change just the "Submit Feedback" option in the panel menu to point to the new pref when opening a tab. The end-of-call every six months feedback form should stay pointing to the existing loop.feedback.formURL pref.

Comment 9

[David Critchley (:dcritch)]

Attachment: Attachment to Bug 1201902 - Feedback link in conversation window should point to a different URL

Add new feedback link to panel menu

Comment 10

[David Critchley (:dcritch)]

Waiting for https://bugzilla.mozilla.org/show_bug.cgi?id=1221739

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8686742 [details] [diff] [review]
Attachment to Bug 1201902 - Feedback link in conversation window should point to a different URL

Review of attachment 8686742 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Ideally we should wait a day or so for bug 1221739 to be live before we land this.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e37dcb50abc2

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e37dcb50abc2

Comment 14

[Bogdan Maris, Desktop QA]

I tested using latest Nightly on Ubuntu 14.04 32-bit and Mac OS X 10.11.1. Hitting 'Submit feedback' from both conversation window and hello panel redirect to loop.feedback.formURL not manualFormURL. 

Reopening this bug as per discussing on irc with Mark. This has regressed from bug 1048850.

Comment 15

[:shell escalante]

ready for re-landing against the latest.

Comment 16

[Mike de Boer [:mikedeboer]]

Attachment: Patch 1.ad: re-add new feedback link to Loop's panel menu

Comment 17

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/ade2734419a41fc0d881c34fa255b5c828c4b873
Bug 1201902 - Add new feedback link to Loop's panel menu. r=Standard8

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ade2734419a4

Comment 19

[Ada [:adalucinet]]

Verified fixed with latest Nightly 45.0a1 (from 2015-12-03), across platforms [1].

[1] Windows 8.1 64-bit, Mac OS X 10.11 and Ubuntu 12.04 32-bit

Comment 20

[Mark Banner (:standard8)]

Attachment: Patch for beta

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello feedback forms
[User impact if declined]: Users will have access to the form that's designed for giving conversation feedback rather than general feedback about the product. This affects our statistics and makes it harder to assess the quality feedback from release to release.
[Describe test coverage new/current, TreeHerder]: Has been on central & aurora for quite a while now. Has tests.
[Risks and why]: Low, small change to load a different URL.
[String/UUID change made/needed]: None

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Mark, Alexandra verified this bug when it was in nightly (45 at this time), now, 45 is in aurora. So, we should have this patch already?!
Thanks

Comment 22

[Mark Banner (:standard8)]

Comment on attachment 8705594 [details] [diff] [review]
Patch for beta

Opps, I set the wrong flag (the patch name said beta ;-) ).

This is meant for beta / 44.

Comment 23

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8705594 [details] [diff] [review]
Patch for beta

The patch seems extremely low risk and giving our end-users the correct survey increases the likelihood of getting valuable feedback which will ultimately help us improve our Hello conv quality. Beta44+

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad6e0f8d7bd3

Comment 25

[Ada [:adalucinet]]

Verified fixed with 44.0b8 (Build ID: 20160111185352), across platforms [1] - both options to leave Feedback (via Hello panel and at the end of the 1st conversation) point to the correct URLs.

[1] Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ad6e0f8d7bd3