Status
People
(Reporter: nyee, Assigned: mikehenrty)
Tracking
Firefox Tracking Flags
(feature-b2g:2.5+)
Details
Attachments
(1 attachment)
|
46 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
|
Details | Review | Splinter Review |
| Comment hidden (empty) |
|
(Reporter) | |
Updated•3 years ago
|
||
feature-b2g: --- → 2.5+
|
||
Comment 1•3 years ago
|
||
Created attachment 8667263 [details] [review] [gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master
|
(Assignee) | |
Comment 2•3 years ago
|
||
Comment on attachment 8667263 [details] [review] [gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master Kevin, can you take a look here?
Attachment #8667263 -
Flags: review?(kevingrandon)
|
||
Comment 3•3 years ago
|
||
Comment on attachment 8667263 [details] [review] [gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master Code looks good to me. I didn't test this because I didn't feel like filling up my SDCard with images or something, but seems like it should work. Thanks!
Attachment #8667263 -
Flags: review?(kevingrandon) → review+
|
|
(Assignee) | |
Comment 4•3 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/98dd8a3bb3a9498a2dc22b8fdeb97f714fe4e9bf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Hey Michael, I know this is a 2.5 No Go, and is 'resolved'... but we had a string review and we have an update. IxD and VsD Specs will be updated to reflect this change. Please update strings from 'Low Device Storage' to 'Critically Low Storage' Impacts: • Settings App: Application Storage, Media Storage & App Permission • System App: Lockscreen, System Toast & Utility Tray Notifications • Message App: Low Storage Notice • Dialer App: Low Storage Notice and Incoming/Outgoing Call Notifications thanks!
Flags: needinfo?(mhenretty)
|
|
(Assignee) | |
Comment 6•3 years ago
|
||
Hi Katie, please file a new bug for these string changes.
Flags: needinfo?(mhenretty)
Done. :) Bug 1212040 - Update string in system banner low storage warning
You need to log in
before you can comment on or make changes to this bug.