1201930 - Show system banner warning at every app launch.

Status: RESOLVED FIXED

Description

[Nicole Yee (:nicoleyee)]

Comment 1

[GitHub Autolander Bot]

Created attachment 8667263 [details] [review]
[gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8667263 [details] [review]
[gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master

Kevin, can you take a look here?

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8667263 [details] [review]
[gaia] mikehenrty:bug-1201930-low-storage-banner > mozilla-b2g:master

Code looks good to me. I didn't test this because I didn't feel like filling up my SDCard with images or something, but seems like it should work. Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/98dd8a3bb3a9498a2dc22b8fdeb97f714fe4e9bf

Comment 5

[katieC]

Hey Michael,

I know this is a 2.5 No Go, and is 'resolved'... but we had a string review and we have an update. IxD and VsD Specs will be updated to reflect this change. 

Please update strings from 'Low Device Storage' to 'Critically Low Storage'

Impacts:
• Settings App: Application Storage, Media Storage & App Permission
• System App: Lockscreen, System Toast & Utility Tray Notifications
• Message App: Low Storage Notice
• Dialer App: Low Storage Notice and Incoming/Outgoing Call Notifications

thanks!

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Hi Katie, please file a new bug for these string changes.

Comment 7

[katieC]

Done. :) Bug 1212040 - Update string in system banner low storage warning