Closed Bug 1201936 Opened 9 years ago Closed 9 years ago

Langfile parser accepts invalid langfiles

Categories

(Webtools Graveyard :: Pontoon, defect)

Product:
Webtools Graveyard
Component:
Pontoon
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox43 --- affected

People

(Reporter: osmose, Unassigned)

Details

http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/firefoxhealthreport/locale/en-US/date.lang?view=markup&sortby=file is an invalid langfile that somehow made it into FHR. Pontoon's langfile parser for sync_projects currently accepts it as a valid langfile, when it should reject it and ignore the resource.

Specifically, langfiles are not allowed to have empty translations.
Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/a69d389eb7b49ad14c425a8eb71a0eb7882e8eaf
Fix bug 1201936: Ignore files with parse errors.

Also makes langfiles raise parse errors for blank translations.

https://github.com/mozilla/pontoon/commit/463b38219755c3ea5cee55cdbd00c4642176377c
Merge pull request #188 from Osmose/invalid-langfiles

Fix bug 1201936: Handle invalid langfiles with blank translations.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.