Closed Bug 1202014 Opened 4 years ago Closed 4 years ago

Use-after-move in ActorsChild.cpp

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

Details

Attachments

(1 file)

In void BackgroundRequestChild::HandleResponse(const nsTArray<SerializedStructuredCloneReadInfo>& aResponse). serializedCloneInfo is used after it is moved into cloneReadInfo. This is safe right now because the moved properties are not accessed after it is moved, however it is a bit sketchy.
I think that this should avoid the use-after-move problem, and should have the same behavior.
Attachment #8657411 - Flags: review?(khuey)
Assignee: nobody → michael
https://hg.mozilla.org/mozilla-central/rev/23231987a74c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.