Closed Bug 1202028 Opened 4 years ago Closed 4 years ago

Make c++11 iter thing for iterating each frame in a SavedFrame stack

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

I feel it would improve a lot of our loops over SavedFrame stacks, for example this one: https://dxr.mozilla.org/mozilla-central/rev/7f987c38bd3e5ac9a834981e85378bdb02338e9d/js/src/vm/SavedStacks.cpp#1148-1160
Comment on attachment 8658298 [details] [diff] [review]
Implement range based for loops for SavedFrame stacks

Review of attachment 8658298 [details] [diff] [review]:
-----------------------------------------------------------------

Neat!
Attachment #8658298 - Flags: review?(terrence) → review+
try closed; reminder to push to try
Flags: needinfo?(nfitzgerald)
This new revision fixes the bad header include ordering that made the style checker unhappy in that earlier try push.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0e5d2f83896b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.