Closed Bug 1202051 Opened 5 years ago Closed 5 years ago

Use a PersistentRooted to automate tracing of unwrappedException_

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file)

The use of |throwing| rather than |unwrappedException.isMarkable()| to chose when we keep the exception live seems worryingly prone to leaving dead pointers around in the heap, although I was not able to find any places where they (obviously) get out of sync.
Attachment #8657342 - Flags: review?(sphink)
Comment on attachment 8657342 [details] [diff] [review]
un_special_case_unwrappedException_rooting-v0.diff

Review of attachment 8657342 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know, this could badly regress the cases where you have >1M JSContexts live...
Attachment #8657342 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/0fda784c6682
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.