208.53 KB, text/plain
500.63 KB, image/jpeg
402.12 KB, image/jpeg
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Created attachment 8657359 [details] logcat_20150904_1549.txt Description: When you send SMS text with Subject text and with message. The text will overlap. Repro Steps: 1) Update a Aries to 20150903161537 2) Launch the messanger app. 3) After typing phone number add a subject 4) Type couple lines of text of couple lines inside a subject body 5) Send a message. 6) Click the message that you send, click on message and hold. 7) Click on Message Report Actual: Observe that After MMS message is send. Inside the message report the subject text overlaps SMS text. Expected: The subject text should not overlap SMS text inside the message body. Environmental Variables: Device: Aries 2.5 kk Full Flash (319 mb) Build ID: 20150903161537 Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7 Gecko: feee8b89453a42346f20753bd1b8a606c286f561 Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 43.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0 Repro frequency: 3/3 See attached: Video and Logcat
This issue also occurs on Flame 2.5 Report: Subject text overlaps MMS text inside the Message Report Environmental Variables: Device: Flame 2.5 kk Full Flash (319 mb) Build ID: 20150903150222 Gaia: d7385b79e68d4ad662cacf810506e9ee53345d23 Gecko: 7f987c38bd3e5ac9a834981e85378bdb02338e9d Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd Version: 43.0a1 (2.5) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0 --------------------------------------------------------------------- This issue also occurs on Flame 2.2 Report Subject text overlaps MMS text inside the Message Report Environmental Variables: Device: Flame 2.2 kk Full Flash (319 mb) Build ID: 20150903183008 Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46 Gecko: d3cb4f28c735 Gonk: bd9cb3af2a0354577a6903917bc826489050b40d Version: 37.0 (2.2) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage+]
status-b2g-v2.2: --- → affected
status-b2g-master: --- → affected
This issue is not a regression and seems minor so not nominating to block on this.
It should be relatively simple issue for css fix.
Whiteboard: [2.5-Daily-Testing][Spark] → [2.5-Daily-Testing][Spark][sms-papercuts][lang=css][good first bug]
This is happening with only a long word as a subject. Morpheus, what should be the right behavior? Have an ellipsis for the long word (so we wouldn't see the full text.. but after all we see the full subject in the conversation panel already)? Or have it wrap in the middle of the word?
The system has already defined a maximum length of subject. It means the text in the message report won't be too long to display. So I would recommend to wrap the text in the middle of the word, and take care of the overlapping and line spacing. Ni Fang to review the line spacing.
Flags: needinfo?(mochen) → needinfo?(fshih)
Created attachment 8661096 [details] Message report_text_wrap.jpg Attached the spec for the line spacing. Thanks!
I would not mind taking this bug if somebody can assign it to me please! I already started looking at it, hopefully will have a good solution soon.
yeah, sure :) Feel free to comment if you stuck anywhere. Thanks
Assignee: nobody → jgw9617
See PR for first attempt above! Let me know of any changes that need to be made, I tried to keep the necessary changes to a minimum.
Comment on attachment 8696606 [details] [review] [gaia] jgw96:long-subject-fix > mozilla-b2g:master Hi, Thanks for the PR. will check it soon :) First go with feedback flag before review :) Thanks
Attachment #8696606 - Flags: review?(felash) → feedback?(felash)
Awesome! Let me know if any changes need to be made please
Yes, sorry for the delay, we've been all week long in a workweek. Normal work resumes next week.
No problem, sounds good to me.
Comment on attachment 8696606 [details] [review] [gaia] jgw96:long-subject-fix > mozilla-b2g:master Hey Justin, Well, your patch does not work properly. Have you tried it at all ? You didn't change the main "index.html" but only conversation/index.html, and when I tried to display the report view, it's broken... Also did you look at the attachment 8661096 [details] ? You'll find the spec to implement there. Here are the main changes to the current behavior: * use the default line-height (that is: "line-height: 1" instead of "line-height: 1.1rem" * use better margin between lines. (currently we use a padding) * there is an indentation when the text has several lines. I'd suggest to use flexbox to implement this. You can have a look at  for more information. Also the issue may happen in other places than just the subject, for example I see it could happen for dates as well, in rare cases.  https://css-tricks.com/snippets/css/a-guide-to-flexbox/ I'd like that you at least test your code yourself before asking feedback. We can provide some guidance but it's easier if you do some of the check yourself, at least for the main case. Thanks anyway for your work, I surely hope to find an updated patch soon !
Attachment #8696606 - Flags: feedback?(felash) → feedback-
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.