1202099 - clang 3.7 build failure in zlib

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(no longer active)]

I get this when building Firefox with clang 3.7:

 4:38.27 /Users/ehsan/moz/src/modules/zlib/src/inflate.c:1507:61: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
 4:38.27     if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
 4:38.27                                                         ~~~ ^
 4:38.28 1 error generated.

This warning is turned on by -Wall, and we treat warnings as errors, hence the error message.

I have upstreamed a patch here: https://github.com/madler/zlib/pull/112

Comment 1

[(no longer active)]

Attachment: Fix a clang 3.7 build warning (treated as error) in zlib

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8657400 [details] [diff] [review]
Fix a clang 3.7 build warning (treated as error) in zlib

Review of attachment 8657400 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/zlib/src/inflate.c
@@ +1503,5 @@
>  z_streamp strm;
>  {
>      struct inflate_state FAR *state;
>  
> +    if (strm == Z_NULL || strm->state == Z_NULL) return (unsigned)-1L << 16;

This won't return the same value as without the cast on LP64 platforms.

Comment 3

[(no longer active)]

Right...  I'm just going to land this commit from upstream: https://github.com/madler/zlib/commit/e54e1299404101a5a9d0cf5e45512b543967f958.patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99df11976340

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/99df11976340