Closed Bug 1202101 Opened 4 years ago Closed 4 years ago

Android cppunit tests do not push all libs using --localLib

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Remote (Android) cppunit tests push libraries to device to support the test executables. Libraries are either extracted from the apk (when --localApk is specified) or found in the specified directory (when --localLib is specified).

All is well when --localApk is used, but with --localLib, not all libraries are pushed.
Current builds put some stripped libraries in <objdir>/dist/fennec/assets/<arch>/. Including these libraries in the push results in all required libs being pushed.
Attachment #8658331 - Flags: review?(dminor)
Blocks: 1202102
Comment on attachment 8658331 [details] [diff] [review]
check "assets" sub-directories also

Review of attachment 8658331 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change mentioned below.

::: testing/remotecppunittests.py
@@ +88,5 @@
>                      for file in files:
>                          if (file.endswith(".so")):
>                              remote_file = posixpath.join(self.remote_bin_dir, file)
>                              self.device.pushFile(os.path.join(root, file), remote_file)
> +            # ...or in a subdirectory of "assets"

I think we should keep the subdirectories in a list to cut down on code duplication, something like this:

for subdir in ["assets", "lib"]:
    local_arm_lib = os.path.join(self.options.local_lib, subdir)
Attachment #8658331 - Flags: review?(dminor) → review+
https://hg.mozilla.org/mozilla-central/rev/f0449939f79e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.