1202114 - Broken link to 3liz.com

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[garyt]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35
Build ID: 20150827182544

Steps to reproduce:

1. goto http://www.seamonkey-project.org/doc/2.0/geolocation
2. First paragraph click on 'Give it a try'


Actual results:

The requested URL /geolocation/ was not found on this server.


Expected results:

The page should have loaded

Comment 1

[Rainer Bielefeld]

Reproducible. On <http://www.seamonkey-project.org/doc/2.0/geolocation> link behind  "Give it a try!" <http://www.3liz.com/geolocation/> causes error 404, because target does not (no longer?) exist. I haven't a clue what contents was shown on old target page and what new contents should be linked.

Comment 2

[Rainer Bielefeld]

a)Solution: simply drop "Give it a try!" with link behind it"

Comment 3

[E Lee]

I'd like to fix this as my first bug, but I need some help getting set up first.

Comment 4

[Philip Chee]

(In reply to E Lee from comment #3)
> I'd like to fix this as my first bug, but I need some help getting set up
> first.

The source code for our website is at:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/
You will need a working installation of the Mercurial version control system:
https://www.mercurial-scm.org/downloads

Comment 5

[Alan]

I have the code base and was able to build. I would like to be assigned this bug. From reading the comments above it seems I just need to remove the "Give it a Try" phrase and link.

Comment 6

[Rainer Bielefeld]

(In reply to Alan from comment #5)
> I would like to be assigned 

Great. It's not necessary that you are ASSIGNED to this bug, you can simply start to create a patch; but I assigned you due to facts.

I will send to you some additional hints "how to start" by Email. For further questions directly related to the reported bug please ask here in comments, for more general questions (I can't find out how to ask for patch review" or similar) I recommend to ask at Newsgroup mozilla.dev.apps.seamonkey.

Comment 7

[Alan]

I used DXR and the code layout to try to pinpoint the location of the file for this page, however, I can't find it anywhere. I have comm-central and mozilla-central.

Comment 8

[Rainer Bielefeld]

(In reply to Alan from comment #7)
I recommend to ask for assistance for such general how tos at  irc://moznet/seamonkey or mozilla.dev.apps.seamonkey (please see recommended wiki chapter)
You find the source at <https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/log/default/src/index.en.html>

Comment 9

[Philip Chee]

Our website source code is stored in a Mercurial repository:
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/

Comment 10

[Philip Chee]

See also Bug 1325556 for an example.

Comment 11

[Alan]

Attachment: Dropped "Give it a try!"

I have been trying to submit on ReviewBoard, however, the auto review isn't able to find an appropriate review repository. Am I doing something incorrectly?

Comment 12

[Philip Chee]

Comment on attachment 8825216 [details] [diff] [review]
Dropped "Give it a try!"

(In reply to Alan from comment #11)
> Created attachment 8825216 [details] [diff] [review]
> Dropped "Give it a try!"
> 
> I have been trying to submit on ReviewBoard, however, the auto review isn't
> able to find an appropriate review repository. Am I doing something
> incorrectly?
Nope. More likely ReviewBoard doesn't know about this repository. You'll have to generate a git format compliant patch and attach it manually to this bug.

Comment 13

[Alan]

(In reply to Philip Chee from comment #12)
> Comment on attachment 8825216 [details] [diff] [review]
> Dropped "Give it a try!"
> 
> (In reply to Alan from comment #11)
> > Created attachment 8825216 [details] [diff] [review]
> > Dropped "Give it a try!"
> > 
> > I have been trying to submit on ReviewBoard, however, the auto review isn't
> > able to find an appropriate review repository. Am I doing something
> > incorrectly?
> Nope. More likely ReviewBoard doesn't know about this repository. You'll
> have to generate a git format compliant patch and attach it manually to this
> bug.

I assume you want me to use https://git-scm.com/docs/git-format-patch to do this. I just want to make sure.

Comment 14

[Philip Chee]

> I assume you want me to use https://git-scm.com/docs/git-format-patch to do
> this. I just want to make sure.

Yes Mercurial will generate git style patches if you configure it right.

[diff]
git = True
ignoreblanklines = False
ignorews = False
ignorewsamount = False
nodates = True
showfunc = True
unified = 8
patience = 1

Comment 15

[Alan]

Attachment: Git styled patch

Comment 16

[Philip Chee]

If you don't have write access to the repository you can set the checkin-needed keyword. Eventually someone will notice and check it in for you. Cheers.

Comment 17

[Alan]

(In reply to Philip Chee from comment #16)
> If you don't have write access to the repository you can set the
> checkin-needed keyword. Eventually someone will notice and check it in for
> you. Cheers.

Perfect thanks for the tip. I will know for next time.

Comment 18

[Philip Chee]

Pushed to seamonkey-project-org
> Changeset: https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/40efe78e322ba36ca90fb51e9

Note: changed the commit message to be clearer:
> Bug 1202114 Fix broken link to 3liz.com r=IanN a=Ratty
> Followed solution by Rainer Bielefeld by dropping "Give it a try!" and the link. The 3liz.com link caused a 404 error.
1. Added the bug number
2. Added r=IanN since Ian reviewed the code.