1202126 - alternative keyboard layout "neo" has english auto correction & word suggestion, but it should be german

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Valérie Labonté]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826190045

Steps to reproduce:

Flame, Firefox OS version 2.5.0.0-prerelease.

1. add the "neo" keyboard layout in settings/keyboards/select keyboards
2. enable "auto correction" and "word suggestion" in settings/keyboards/buit-in keyboard
3. on the keyboard select "neo" layout (marked "en") & type something


Actual results:

a. auto spelling correction and word suggestions are for english language
b. on the small button in the last row that allows to switch between keyboards neo layout is marked with "en"


Expected results:

As neo layout is an ergonomic keyboard especially for the german language (http://neo-layout.org/) spelling correction and word suggestions should be for german language. The button to change between keyboards should say "de" (for "deutsch" = german) instead of "en".

Comment 1

[Michael Kohler [:mkohler]]

In Gaia this is actually "en-Neo". I'm not sure if this is wanted. There are two possibilities here:

1) Change en-Neo to de-Neo or neo
2) Leave as it is and add "de-Neo" as well

Tim, any feedback on this? Which direction should be gone here?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

According to discussion in bug 1046036 we should do (2). Thanks.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] MichaelKohler:bug1202126 > mozilla-b2g:master

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8669465 [details] [review]
[gaia] MichaelKohler:bug1202126 > mozilla-b2g:master

The git commit message should be documenting the fix, not the bug. Please update that. Thanks!

Comment 5

[Michael Kohler [:mkohler]]

Thanks for the review, Tim. I fixed the test failure and changed the commit message. Could you please have a look again?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Nice!

master: https://github.com/mozilla-b2g/gaia/commit/27f3d85b429c056dd80c9d628411fd346469c425