1202138 - IonMonkey: MIPS32: Fix callAndPushReturnAddress with Label

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

In file included from /home/heiher/git/mips64/gecko-dev/js/src/mips32-release/js/src/Unified_cpp_js_src7.cpp:11:0:
/home/heiher/git/mips64/gecko-dev/js/src/jit/mips32/MacroAssembler-mips32.cpp: In member function 'void js::jit::MacroAssembler::callAndPushReturnAddress(js::jit::Label*)':
/home/heiher/git/mips64/gecko-dev/js/src/jit/mips32/MacroAssembler-mips32.cpp:3463:18: error: no matching function for call to 'js::jit::MacroAssembler::as_jalr(js::jit::Label*&)'
     as_jalr(label);
                  ^

Comment 1

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS32-Fix-callAndPushReturnAddress-with-L.patch

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8657444 [details] [diff] [review]
0001-IonMonkey-MIPS32-Fix-callAndPushReturnAddress-with-L.patch

Review of attachment 8657444 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/MacroAssembler-mips32.cpp
@@ +3460,2 @@
>  {
>      // Push return address during jalr delay slot.

Update this comment as well.

Comment 3

[hev [:hev]]

Attachment: IonMonkey-MIPS32-Fix-callAndPushReturnAddress-with-Label.patch

Update comment based on Attachment 8657444 [details] [diff], please check-in this patch.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1af3c0789763

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1af3c0789763