1202175 - Building Firefox with EGL fails

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Johannes Pfrang [:johnp]]

Building Firefox --with-gl-provider=EGL fails with the error:

    ShadowLayerUtilsX11.cpp: In constructor ‘mozilla::layers::SurfaceDescriptorX11::SurfaceDescriptorX11(gfxXlibSurface*, bool)’:
    ShadowLayerUtilsX11.cpp:79:25: error: ‘class gfxXlibSurface’ has no member named ‘GetGLXPixmap’
        mGLXPixmap = aSurf->GetGLXPixmap();

The code has been added in bug 1187440 on July 31st.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Guard GLX-specific call in SurfaceDescriptorX11.

Here's a quick fix that guards the call appropriately; thanks.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71e6964ff7c4

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/71e6964ff7c4