IonMonkey: MIPS32: Move compat functions to MacroAssemblerMIPSCompat

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

unspecified
mozilla43
Other
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

4 years ago
1. Move compat functions to MacroAssemblerMIPSCompat:
Operand ToPayload(Operand base);
Address ToPayload(Address base);
Operand ToType(Operand base);
Address ToType(Address base);
void convertBoolToInt32(Register source, Register dest);
void convertInt32ToDouble(Register src, FloatRegister dest);
void convertInt32ToDouble(const Address& src, FloatRegister dest);
void convertInt32ToDouble(const BaseIndex& src, FloatRegister dest);
void convertUInt32ToDouble(Register src, FloatRegister dest);
void convertUInt32ToFloat32(Register src, FloatRegister dest);
void convertDoubleToFloat32(FloatRegister src, FloatRegister dest);
void branchTruncateDouble(FloatRegister src, Register dest, Label* fail);
void convertDoubleToInt32(FloatRegister src, Register dest, Label* fail, bool negativeZeroCheck = true);
void convertFloat32ToInt32(FloatRegister src, Register dest, Label* fail, bool negativeZeroCheck = true);
void convertFloat32ToDouble(FloatRegister src, FloatRegister dest);
void branchTruncateFloat32(FloatRegister src, Register dest, Label* fail);
void convertInt32ToFloat32(Register src, FloatRegister dest);
void convertInt32ToFloat32(const Address& src, FloatRegister dest);
void addDouble(FloatRegister src, FloatRegister dest);
void subDouble(FloatRegister src, FloatRegister dest);
void mulDouble(FloatRegister src, FloatRegister dest);
void divDouble(FloatRegister src, FloatRegister dest);
void computeScaledAddress(const BaseIndex& address, Register dest);
void computeEffectiveAddress(const Address& address, Register dest);
void computeEffectiveAddress(const BaseIndex& address, Register dest);

2. Move asMasm() to MacroAssemblerMIPS and mark as protected.
Assignee

Updated

4 years ago
Assignee: nobody → r
Assignee

Updated

4 years ago
Blocks: 1194139
Assignee

Comment 1

4 years ago
Attachment #8657554 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8657554 [details] [diff] [review]
Move-compat-functions-to-MacroAssemblerMIPSCompat.patch

Review of attachment 8657554 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/MacroAssembler-mips32.h
@@ +1357,3 @@
>      bool buildOOLFakeExitFrame(void* fakeReturnAddr);
>  
> +public:

nit: welcome to to world of half-indented lines.  To make it simple, if your line ends with a colon, it should be half indented.  Such as visibility keywords, labels, and case statements.
Attachment #8657554 - Flags: review?(nicolas.b.pierron) → review+
Assignee

Comment 3

4 years ago
Fix indent.
Attachment #8659685 - Flags: review+
Attachment #8659685 - Flags: checkin?
Assignee

Updated

4 years ago
Keywords: checkin-needed
Attachment #8659685 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/95f8c872196f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.