Closed Bug 1202287 Opened 9 years ago Closed 9 years ago

Remove end padding on URL bar (reload/stop/go buttons look unbalanced)

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox40 --- unaffected
firefox41 --- verified
firefox42 --- verified
firefox43 --- verified

People

(Reporter: ntim, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

padding
1.57 KB, patch
ntim
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review
It makes the reload button unbalanced (more spacing on right than left).
Attached patch patch (obsolete) — — Splinter Review
Good find, we should also uplift this
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8657719 - Flags: review?(ntim.bugs)
Blocks: 1185960, 1192839
status-firefox40: --- → unaffected
status-firefox41: --- → affected
status-firefox42: --- → affected
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Remove end padding on URL bar → Remove end padding on URL bar (reload/stop/go buttons look unbalanced)
Attached patch padding — — Splinter Review
missed another place where we set the padding
Attachment #8657719 - Attachment is obsolete: true
Attachment #8657719 - Flags: review?(ntim.bugs)
Attachment #8657727 - Flags: review?(ntim.bugs)
Comment on attachment 8657727 [details] [diff] [review] padding Review of attachment 8657727 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me !
Attachment #8657727 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Comment on attachment 8657727 [details] [diff] [review] padding Approval Request Comment [Feature/regressing bug #]: bug 1185960 [User impact if declined]: reload/stop/go buttons in the location bar look unbalanced on Windows and OS X [Describe test coverage new/current, TreeHerder]: [Risks and why]: low-risk code removal, makes Windows and OS X consistent with Linux [String/UUID change made/needed]:
Attachment #8657727 - Flags: approval-mozilla-beta?
Attachment #8657727 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d65b4a24e693
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment on attachment 8657727 [details] [diff] [review] padding This patch just removes padding so it's safe to uplift to Beta41 and Aurora42.
Attachment #8657727 - Flags: approval-mozilla-beta?
Attachment #8657727 - Flags: approval-mozilla-beta+
Attachment #8657727 - Flags: approval-mozilla-aurora?
Attachment #8657727 - Flags: approval-mozilla-aurora+
I'm hitting conflicts uplifting this to beta. Can we get a rebased patch for beta?
Flags: needinfo?(dao)
Flags: qe-verify+
QA Contact: cornel.ionce
I reproduced this bug on Firefox Nightly Version 43.0a1 It's verified and fixed on Latest Firefox Nightly and Developer Edition Latest Nightly Build ID 20150909030223 User Agent Mozilla/5.0 (Windows NT 6.1; rv:43.0) Gecko/20100101 Firefox/43.0 Latest Developer Edition Build ID 20150909004021 User Agent Mozilla/5.0 (Windows NT 6.1; rv:42.0) Gecko/20100101 Firefox/42.0 Tested OS-- windows7 32bit
QA Whiteboard: [testday-20150911]
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified
We should get this verified on all platforms, at least for 41 since that's very close to release.
Per comment 12.
Status: VERIFIED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox42: verified → fixed
status-firefox43: verified → fixed
Confirming this on Firefox 41 beta 9 build ID: 20150910171927. Verified on Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
Also verified on latest Nightly, build ID: 20150916030203 and latest Aurora, build ID: 20150916004013.
status-firefox42: fixed → verified
status-firefox43: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: